git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Nick Edelen <sirnot@gmail.com>
Cc: Nicolas Pitre <nico@cam.org>,
	sam@vilain.net, git@vger.kernel.org,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Andreas Ericsson <exon@op5.se>,
	Christian Couder <christian@couder.net>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH] Shift object enumeration out of upload-pack
Date: Sun, 07 Jun 2009 19:36:51 -0700	[thread overview]
Message-ID: <7vvdn78n98.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <c77435a80906071834m1600d23dpb4a1b58c7a61361d@mail.gmail.com> (Nick Edelen's message of "Mon\, 8 Jun 2009 03\:34\:28 +0200")

Nick Edelen <sirnot@gmail.com> writes:

> okie dokie.  is this good?

No.  The above line should be after "---".

> From: Nick Edelen <sirnot@gmail.com>
> Subject: [PATCH] Shift object enumeration out of upload-pack

And these two are not necessary, as you are not forwarding somebody else's
mail nor sending from an account that you do not to be recorded as the
author (i.e. your RFC2822 "From: " header is the same as this one).

> Offload object enumeration in upload-pack to pack-objects, but fall
> back on internal revision walker for shallow interaction.  Test t5530
> updated to reflect mechanism change.

Here, "to reflect mechanism change" is not quite a good enough
description.  Your explanation to Nico was much better.

> Signed-off-by: Nick Edelen <sirnot@gmail.com>
> Acked-by: Nicolas Pitre <nico@cam.org>

By the way, the proposed commit log message describes what the patch does
(i.e. "shifts enumeration from one process to the other"), but does not
answer more important question.  Please say _why_ it is a good idea to do
so in the message.

Thanks.

  parent reply	other threads:[~2009-06-08  2:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08  1:34 [PATCH] Shift object enumeration out of upload-pack Nick Edelen
2009-06-08  2:12 ` Nicolas Pitre
2009-06-08  2:36 ` Junio C Hamano [this message]
2009-06-09 23:50   ` Nick Edelen
2009-06-10  7:20     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvdn78n98.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=christian@couder.net \
    --cc=exon@op5.se \
    --cc=git@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=peff@peff.net \
    --cc=sam@vilain.net \
    --cc=sirnot@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).