From: Junio C Hamano <gitster@pobox.com>
To: William Pursell <bill.pursell@gmail.com>
Cc: Alex Riesen <raa.lkml@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
git@vger.kernel.org
Subject: Re: permissions
Date: Sun, 06 Jun 2010 12:54:05 -0700 [thread overview]
Message-ID: <7vvd9wvswy.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4C0B6C32.1090700@wpursell.net> (William Pursell's message of "Sat\, 05 Jun 2010 23\:36\:50 -1000")
William Pursell <bill.pursell@gmail.com> writes:
> The problem is permissions, not that it's "not a git repository".
> The error message should be "permission denied". The easy solution
> is to abort with "permission denied" whenever that is encountered,
> but the trouble with that is that it breaks the current work flow
> in which a broken dir (or one for which the user lacks
> priveleges) is bypassed and a valid object directory higher
> up in the filesystem tree is used.
I think it is sane to abort with "permission denied", as it is "not a git
repository" but it is "we cannot even determine if that .git we see is a
git repository, and if it is, then we cannot do any git operation here as
we cannot read it". As to what you call "the current work flow", I think
it is not like we _support_ such usage, but more like it _happens to_ work
that way.
> A related question is: does anyone actually prefer (or rely on) the
> current model in which ../.git is used in the event that .git is borked
> or the user lacks permission?
So my answer to this is "nobody _should_", as it is not even "the current
model", but "it happens to behave like that by accident". That doesn't
mean there isn't anybody who already does, though...
next prev parent reply other threads:[~2010-06-06 19:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 9:33 permissions William Pursell
2010-06-05 9:50 ` permissions Andreas Schwab
2010-06-05 18:23 ` permissions William Pursell
2010-06-06 6:45 ` permissions Alex Riesen
2010-06-06 9:36 ` permissions William Pursell
2010-06-06 12:45 ` permissions Alex Riesen
2010-06-06 19:54 ` Junio C Hamano [this message]
2010-06-08 10:25 ` permissions William Pursell
2010-06-08 14:52 ` permissions Alex Riesen
2010-06-08 21:05 ` permissions Junio C Hamano
2010-06-08 22:27 ` permissions William Pursell
2010-06-09 7:20 ` permissions Alex Riesen
2010-06-09 10:29 ` permissions William Pursell
2010-06-09 12:06 ` permissions Thomas Rast
2010-06-09 13:00 ` permissions Alex Riesen
2010-06-09 12:56 ` permissions Alex Riesen
2010-06-09 10:39 ` permissions Steven Michalske
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvd9wvswy.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bill.pursell@gmail.com \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).