From: Junio C Hamano <gitster@pobox.com>
To: Jochen Schmitt <Jochen@herr-schmitt.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix wrong xhtml option to highlight
Date: Mon, 24 Jan 2011 14:48:25 -0800 [thread overview]
Message-ID: <7vvd1dlxza.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1295898298-9794-1-git-send-email-Jochen@herr-schmitt.de> (Jochen Schmitt's message of "Mon\, 24 Jan 2011 20\:44\:58 +0100")
Jochen Schmitt <Jochen@herr-schmitt.de> writes:
> ---
> Hallo,
>
> because I'm the maintainer of the highlight package in the
> Fedora Project I was notified, that highlight doesn't works
> properly with gitweb in BZ #672293.
>
> So I have create the following simple patch to solve the
> reported issue.
>
> Best Regards
>
> Jochen Schmitt
>
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 1025c2f..b662420 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3468,7 +3468,7 @@ sub run_highlighter {
> close $fd;
> open $fd, quote_command(git_cmd(), "cat-file", "blob", $hash)." | ".
> quote_command($highlight_bin).
> - " --xhtml --fragment --syntax $syntax |"
> + " -xhtml --fragment --syntax $syntax |"
Curious.
Does the command take double-dash for the fragment and syntax options but
a single dash for the xhtml option? Really...
A few top hits returned by Google for "highlight manual page" tells me
otherwise.
next prev parent reply other threads:[~2011-01-24 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 19:44 [PATCH] Fix wrong xhtml option to highlight Jochen Schmitt
2011-01-24 22:48 ` Junio C Hamano [this message]
2011-01-27 1:44 ` Drew Northup
2011-01-27 19:00 ` Junio C Hamano
2011-01-28 12:35 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvd1dlxza.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jochen@herr-schmitt.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).