From: Junio C Hamano <gitster@pobox.com>
To: 乙酸鋰 <ch3cooli@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-tag documentation enhancement
Date: Sun, 29 Jul 2012 18:13:52 -0700 [thread overview]
Message-ID: <7vvch6t5in.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAHtLG6SQ3DeexriXRtV4ys7x12iKQtq7OCrZdC+A8SSH6Tokow@mail.gmail.com> ("乙酸鋰"'s message of "Sun, 29 Jul 2012 20:33:24 +0800")
乙酸鋰 <ch3cooli@gmail.com> writes:
> I would like to enhance git-tag documentation
>
> --Unless -f is given, the tag to be created must not yet exist in the
> .git/refs/tags/ directory.
> ++Unless -f is given, the tag to be created must not yet exist in the
> .git/refs/tags/ directory or inside .git/packed-refs file.
I think the updated text is technically correct, but I do not think
it is a good direction to go. The root cause of the problem was
that the original text assumed ".git/refs/tags/ directory" will
forever be the only way to have a local tag, and the description was
left behind when packed refs mechanism was introduced to improve the
file system usage. It shouldn't have relied its description on such
an implementation detail in the first place.
The updated text still shares the same problem. I think the right
fix is to say something like this:
Unless -f is given, the tag to be created must not yet exist
as a local tag.
next prev parent reply other threads:[~2012-07-30 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHtLG6TDDmvtt1cc3_mGG9hZtSVp-ecNXzCQrPj6-e4DU6HMGA@mail.gmail.com>
2012-07-29 12:33 ` git-tag documentation enhancement 乙酸鋰
2012-07-30 1:13 ` Junio C Hamano [this message]
2012-08-06 21:04 ` [PATCH] Documentation: do not mention .git/refs/* directories Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvch6t5in.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=ch3cooli@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).