git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jun 2013, #07; Thu, 20)
Date: Fri, 21 Jun 2013 13:31:42 -0700	[thread overview]
Message-ID: <7vvc57kxxt.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALkWK0kDDRicX9VmcRgG9daXVi6W-zGNt=x6ruy7X5MhrHOZbQ@mail.gmail.com> (Ramkumar Ramachandra's message of "Fri, 21 Jun 2013 21:37:47 +0530")

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Junio C Hamano wrote:
>>> - rr/describe-contains-all at  $gmane/228278.
>>
>> This may overlap with a topic in flight (but I didn't look at it).
>
> Let me know if I can do anything to make it easier for you.  I'm quite
> excited about this one.
>
>>> - rr/mixed-case-aliases at $gmane/227959.
>>
>> Personally, not just uninterested but moderately against.
>
> Okay, but I'd like an explanation.

Because the implementation is too ugly.

The damage to the more generic config parser codepath is a real
downside and the benefit from the little "feature" does not seem to
justify it.

I would however can imagine an alternative implementation which
might be more palatable. It may go like this:

	[alias "lgF"]
		command = "log --oneline --boundary --first-parent"
                help = "show the first parent chain, one line per commit"
		completion = log

so that not just alias.c code can take notice of alias.lgF.command
to expand it, but we can later extend it to help "git help lgF" and
bash/zsh completion (i.e. they would learn "lgF parameter would
complete in a way similar to 'log'" from alias.lgF.completion).

  parent reply	other threads:[~2013-06-21 20:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21  4:56 What's cooking in git.git (Jun 2013, #07; Thu, 20) Junio C Hamano
2013-06-21 11:05 ` Ramkumar Ramachandra
2013-06-21 15:51   ` Junio C Hamano
2013-06-21 16:07     ` Ramkumar Ramachandra
2013-06-21 17:07       ` Junio C Hamano
2013-06-21 17:13         ` Ramkumar Ramachandra
2013-06-21 17:32           ` Antoine Pelisse
2013-06-21 18:26           ` Junio C Hamano
2013-06-21 18:49             ` Ramkumar Ramachandra
2013-06-21 20:31       ` Junio C Hamano [this message]
2013-06-22  6:17         ` Ramkumar Ramachandra
2013-06-23 17:21 ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvc57kxxt.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).