From: Junio C Hamano <gitster@pobox.com>
To: Jens Lindstrom <jl@opera.com>
Cc: git@vger.kernel.org, johan@herland.net
Subject: Re: [PATCH] clone: Skip pack-*.keep files when cloning locally
Date: Fri, 28 Jun 2013 11:38:10 -0700 [thread overview]
Message-ID: <7vvc4ynkrx.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1372430538-19216-1-git-send-email-jl@opera.com> (Jens Lindstrom's message of "Fri, 28 Jun 2013 16:42:18 +0200")
Jens Lindstrom <jl@opera.com> writes:
Hmph. I am of two minds here.
> The pack-*.keep files are temporary, and serve no purpose in the
> clone.
They are not temporary, actually. A user can deliberatey create a
"keep" marker after packing with a good set of parameters, so that
the resulting pack will be kept, instead of letting a later repack
(with faster set of parameters) remove and replace it with less
optimal results.
> Worse, though, they are created with access bits 0600, so if the
> user trying to clone the repository is different from the user that
> caused the pack-*.keep file to be created, the clone will likely
> fail due to not being allowed to read (and thus copy) the file in
> the first place.
I am perfectly fine with a change that allows a local clone to skip
and not error out when such a "keep" marker cannot be copied, I do
not know if it is a good idea to unconditionally skip and not even
attempt to copy it.
next prev parent reply other threads:[~2013-06-28 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 14:42 [PATCH] clone: Skip pack-*.keep files when cloning locally Jens Lindstrom
2013-06-28 18:38 ` Junio C Hamano [this message]
2013-06-28 20:38 ` Junio C Hamano
2013-07-01 10:24 ` Jens Lindström
2013-07-01 16:20 ` Junio C Hamano
2013-07-03 10:02 ` Jens Lindström
2013-07-03 17:26 ` Junio C Hamano
2013-07-03 18:31 ` Jens Lindström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvc4ynkrx.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jl@opera.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).