Re: [PATCHv2 3/3] Teach --dirstat to not completely ignore rearranged lines within a file

[Junio C Hamano <gitster@pobox.com>]

Johan Herland <johan@herland.net> writes:

> Currently, the --dirstat analysis fails to detect when lines within a
> file are rearranged, because the "damage" calculated by show_dirstat()
> is 0. However, if the SHA1 sum has changed, we already now that there
> should be at least some minimum amount of damage.

This logic is sensible, modulo that "fails to detect" is actually "ignores
mere line movements on purpose".

In any case, if the object names are different, we already know that there
is _some_ damage, and it is very unintiutive to claim that there is _no_
damage.

> This patch teaches show_dirstat() to assign a minimum amount of damage
> (== 1) to entries for which the analysis otherwise yields zero damage.

So it is perfectly in line with the above logic to give a minimum here.
Zero was simply just unintuitive, and this is a good fix to the problem.

> Obviously this is not a complete fix, but it's at least better to

I however do not understand what "a complete fix" means in this context.
You've fixed the unintuitiveness, and as far as the description in the
introductory paragraph of the problem goes, I think this already is a
complete fix.