From: Junio C Hamano <gitster@pobox.com>
To: Manlio Perillo <manlio.perillo@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-completion.bash: update obsolete code.
Date: Sun, 16 Dec 2012 20:54:52 -0800 [thread overview]
Message-ID: <7vtxrlnuqr.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1355694602-8771-1-git-send-email-manlio.perillo@gmail.com> (Manlio Perillo's message of "Sun, 16 Dec 2012 22:50:02 +0100")
Manlio Perillo <manlio.perillo@gmail.com> writes:
> The git-completion.bash script was using the git ls-tree command
> without the --name-only option, with a sed filter to parse path names;
> use the --name-only option, instead.
>
> Signed-off-by: Manlio Perillo <manlio.perillo@gmail.com>
> ---
Did you miss the different handling between blobs and trees the
latter gets trailing slash in the completion)?
> contrib/completion/git-completion.bash | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 0b77eb1..85d9051 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -397,20 +397,7 @@ __git_complete_revlist_file ()
> *) pfx="$ref:$pfx" ;;
> esac
>
> - __gitcomp_nl "$(git --git-dir="$(__gitdir)" ls-tree "$ls" \
> - | sed '/^100... blob /{
> - s,^.* ,,
> - s,$, ,
> - }
> - /^120000 blob /{
> - s,^.* ,,
> - s,$, ,
> - }
> - /^040000 tree /{
> - s,^.* ,,
> - s,$,/,
> - }
> - s/^.* //')" \
> + __gitcomp_nl "$(git --git-dir="$(__gitdir)" ls-tree --name-only "$ls")" \
> "$pfx" "$cur_" ""
> ;;
> *...*)
next prev parent reply other threads:[~2012-12-17 4:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 21:50 [PATCH] git-completion.bash: update obsolete code Manlio Perillo
2012-12-17 4:54 ` Junio C Hamano [this message]
2012-12-17 16:53 ` Manlio Perillo
2012-12-17 20:29 ` Junio C Hamano
2012-12-18 1:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtxrlnuqr.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=manlio.perillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).