From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: [PATCH v4 3/5] config: make parsing stack struct independent from actual data source
Date: Mon, 13 May 2013 07:54:06 -0700 [thread overview]
Message-ID: <7vtxm7nd69.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130513140435.GC3561@book-mint> (Heiko Voigt's message of "Mon, 13 May 2013 16:04:35 +0200")
Heiko Voigt <hvoigt@hvoigt.net> writes:
> On Sun, May 12, 2013 at 09:56:39PM -0700, Junio C Hamano wrote:
>> Heiko Voigt <hvoigt@hvoigt.net> writes:
>>
>> > /*
>> > - * The fields f and name of top need to be initialized before calling
>> > + * All source specific fields in the union, name and the callbacks
>> > + * fgetc, ungetc, ftell of top need to be initialized before calling
>> > * this function.
>> > */
>> > -static int do_config_from(struct config_file *top, config_fn_t fn, void *data)
>> > +static int do_config_from_source(struct config_source *top, config_fn_t fn, void *data)
>>
>> This renaming may have made sense if we were to have many different
>> do_config_from_$type functions for different types of source, but as
>> this patch introduces a nice "config_source" abstraction, I do not
>> think it is unnecessary. Shortening do_config_from() to do_config()
>> may make more sense, if anything.
>>
>> But that is a very minor point, as this is entirely internal with a
>> single caller.
>
> Did you really intent this double negation: "..., I do not think it
> is unnecessary."
Eh, rather "I think it is unnecessary" or "I do not think it is
necessary".
next prev parent reply other threads:[~2013-05-13 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 13:17 [PATCH v4 0/5] allow more sources for config values Heiko Voigt
2013-05-11 13:18 ` [PATCH v4 1/5] config: factor out config file stack management Heiko Voigt
2013-05-11 13:19 ` [PATCH v4 2/5] config: drop cf validity check in get_next_char() Heiko Voigt
2013-05-11 13:20 ` [PATCH v4 3/5] config: make parsing stack struct independent from actual data source Heiko Voigt
2013-05-13 4:56 ` Junio C Hamano
2013-05-13 14:04 ` Heiko Voigt
2013-05-13 14:54 ` Junio C Hamano [this message]
2013-05-14 2:35 ` Jeff King
2013-05-11 13:21 ` [PATCH v4 4/5] teach config --blob option to parse config from database Heiko Voigt
2013-05-11 13:21 ` [PATCH v4 5/5] do not die when error in config parsing of buf occurs Heiko Voigt
2013-07-01 22:09 ` [PATCH v4 0/5] allow more sources for config values Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtxm7nd69.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=jens.lehmann@web.de \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).