From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Mark Lodato <lodatom@gmail.com>,
git@vger.kernel.org, "Kyle J. McKay" <mackyle@gmail.com>
Subject: Re: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable
Date: Fri, 12 Jul 2013 12:52:09 -0700 [thread overview]
Message-ID: <7vtxjzk13q.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130712190531.GD8482@google.com> (Jonathan Nieder's message of "Fri, 12 Jul 2013 12:05:31 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> FWIW the GIT_SSL_CERT_PASSWORD_PROTECTED envvar has a similar "can
> only enable" behavior, but since it's documented, that's not as big
> of a problem. Do you remember why it was written that way?
Not me ;-).
If I have to guess, it is probably that these two are thought to be
equally trivial way to defeat existing environment settings:
(unset GIT_SSL_CERT_PASSWORD_PROTECTED ; git cmd)
GIT_SSL_CERT_PASSWORD_PROTECTED=no git cmd
> When that setting was first added[1], there was some mention of
> autodetection if libcurl could learn to do that. Did it happen?
I do not think so, but let's see if our resident cURL guru has
something to say about it.
next prev parent reply other threads:[~2013-07-12 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 18:52 [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable Junio C Hamano
2013-07-12 19:05 ` Jonathan Nieder
2013-07-12 19:52 ` Junio C Hamano [this message]
2013-07-14 0:37 ` Mark Lodato
2013-07-15 4:13 ` Junio C Hamano
2013-07-15 6:37 ` Kyle J. McKay
2013-07-15 15:54 ` Junio C Hamano
2013-07-13 19:28 ` Kyle J. McKay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtxjzk13q.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=lodatom@gmail.com \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).