From: Junio C Hamano <gitster@pobox.com>
To: kusmabite@gmail.com
Cc: blees@dcon.de, git@vger.kernel.org, msysgit@googlegroups.com,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 0/2] improve-wincred-compatibility
Date: Sun, 24 Feb 2013 22:43:49 -0800 [thread overview]
Message-ID: <7vsj4k3nbu.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: CABPQNSaUizZPVOeeuEyb=o-Qmm4mYCRxV27qkmp62cSpFkinqA@mail.gmail.com
Erik Faye-Lund <kusmabite@gmail.com> writes:
> On Thu, Jan 10, 2013 at 1:10 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
>> Changes since initial version (see attached diff for details):
>> - split in two patches
>> - removed unused variables
>> - improved the dll error message
>> - changed ?: to if else
>> - added comments
>>
>> Also available here:
>> https://github.com/kblees/git/tree/kb/improve-wincred-compatibility-v2
>> git pull git://github.com/kblees/git.git kb/improve-wincred-compatibility-v2
>>
>> Karsten Blees (2):
>> wincred: accept CRLF on stdin to simplify console usage
>> wincred: improve compatibility with windows versions
>>
>> .../credential/wincred/git-credential-wincred.c | 206 ++++++++-------------
>> 1 file changed, 75 insertions(+), 131 deletions(-)
>>
>
> Wonderful!
>
> Acked-by: Erik Faye-Lund <kusmabite@gmail.com>
I'm in the "marking leftover bits" mode today, and noticed that
nothing happened for this topic in my tree. Did msysgit folks expect
me to pick this up directly, or did you guys want to feed this series
to me (with possibly other changes you worked on outside this list)?
next prev parent reply other threads:[~2013-02-25 6:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 20:28 [PATCH] wincred: improve compatibility with windows versions Karsten Blees
2013-01-04 21:57 ` Erik Faye-Lund
2013-01-08 16:20 ` Karsten Blees
2013-01-08 20:13 ` Erik Faye-Lund
2013-01-10 12:10 ` [PATCH v2 0/2] improve-wincred-compatibility Karsten Blees
2013-01-11 16:20 ` Erik Faye-Lund
2013-02-25 6:43 ` Junio C Hamano [this message]
2013-02-25 23:39 ` Karsten Blees
2013-02-25 23:51 ` Junio C Hamano
2013-02-26 16:55 ` Erik Faye-Lund
2013-02-26 17:29 ` Junio C Hamano
2013-02-26 16:19 ` Johannes Schindelin
2013-01-10 12:10 ` [PATCH v2 1/2] wincred: accept CRLF on stdin to simplify console usage Karsten Blees
2013-01-10 12:10 ` [PATCH v2 2/2] wincred: improve compatibility with windows versions Karsten Blees
2014-09-10 22:32 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsj4k3nbu.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=blees@dcon.de \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).