From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Ian Harvey <iharvey@good.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH 0/4] real reachability checks for upload-archive
Date: Thu, 06 Jun 2013 10:27:48 -0700 [thread overview]
Message-ID: <7vsj0vywrv.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130605223551.GF8664@sigill.intra.peff.net> (Jeff King's message of "Wed, 5 Jun 2013 18:35:51 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Jun 05, 2013 at 12:38:23PM -0400, Jeff King wrote:
>
>> 2. Actually do a reachability check. Doing a full object check to
>> allow fetching an arbitrary tree by sha1 is probably prohibitively
>> expensive[2], but we could allow the form "<commit>[:<path>]", check
>> that "<commit>" is reachable, and then allow arbitrary paths within
>> it.
>
> Thinking on this more, the full reachability check is no worse than what
> a clone has to do to fetch the full repository. Here's a series that
> does the full check. I'm not entirely happy with the performance,
> though; details are in patch 3.
For some repository-servers, it may be OK to enable this by default,
but I suspect it would be better to have at least an opt-out server
configuration.
> I think I'd be tempted to just go the more limiting "commit is
> reachable" route, instead, which would solve your case (and most sane
> cases).
Yes, I think that is a reasonable thing to do. After all, as you
noted in 4/4, you cannot ask for a single blob, and not being able
to ask for a single tree is not much different.
> [1/4]: clear parsed flag when we free tree buffers
> [2/4]: upload-archive: restrict remote objects with reachability check
> [3/4]: list-objects: optimize "revs->blob_objects = 0" case
> [4/4]: archive: ignore blob objects when checking reachability
>
> -Peff
next prev parent reply other threads:[~2013-06-06 17:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 21:18 [BUG] git archive broken in 1.7.8.1 Albert Astals Cid
2012-01-10 21:33 ` Carlos Martín Nieto
2012-01-10 22:05 ` Albert Astals Cid
2012-01-10 22:50 ` Carlos Martín Nieto
2012-01-10 23:21 ` Jeff King
2012-01-11 12:12 ` [PATCH] archive: re-allow HEAD:Documentation on a remote invocation Carlos Martín Nieto
2012-01-11 19:39 ` Jeff King
2012-01-11 19:42 ` [PATCH 1/2] get_sha1_with_context: report features used in resolution Jeff King
2012-01-12 2:36 ` Junio C Hamano
2012-01-12 2:51 ` Jeff King
2012-01-11 19:42 ` [PATCH 2/2] archive: loosen restrictions on remote object lookup Jeff King
2013-05-29 12:05 ` Ian Harvey
2013-06-05 16:38 ` Jeff King
2013-06-05 22:35 ` [RFC/PATCH 0/4] real reachability checks for upload-archive Jeff King
2013-06-05 22:37 ` [PATCH 1/4] clear parsed flag when we free tree buffers Jeff King
2013-06-06 17:55 ` Junio C Hamano
2013-06-05 22:39 ` [PATCH 2/4] upload-archive: restrict remote objects with reachability check Jeff King
2013-06-05 22:40 ` [PATCH 3/4] list-objects: optimize "revs->blob_objects = 0" case Jeff King
2013-06-05 22:40 ` [PATCH 4/4] archive: ignore blob objects when checking reachability Jeff King
2013-06-06 7:57 ` Michael Haggerty
2013-06-07 0:50 ` Eric Sunshine
2013-06-06 17:27 ` Junio C Hamano [this message]
2012-01-12 2:46 ` [PATCH] archive: re-allow HEAD:Documentation on a remote invocation Junio C Hamano
2012-01-12 2:54 ` Jeff King
2012-01-12 2:59 ` Jeff King
2012-01-12 3:03 ` Junio C Hamano
2012-01-12 3:10 ` Jeff King
2012-01-12 3:20 ` Junio C Hamano
2012-01-10 23:01 ` [BUG] git archive broken in 1.7.8.1 Allan Wind
2012-01-11 12:51 ` Carlos Martín Nieto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsj0vywrv.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=iharvey@good.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).