git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Jan Engelhardt <jengelh@computergmbh.de>
Subject: Re: [PATCH] format-patch: set default stat_width to 72
Date: Thu, 03 Apr 2008 23:12:23 -0700	[thread overview]
Message-ID: <7vr6dmywqg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080403102214.GA23121@coredump.intra.peff.net> (Jeff King's message of "Thu, 3 Apr 2008 06:22:14 -0400")

Jeff King <peff@peff.net> writes:

>> format-patch already defaults to "--stat --summary -p" if you give it
>> no format options. The default stat is 80, I believe; for format-patch
>> it should probably be bumped to 72 anyway.

> This should be totally harmless and maint-worthy, I would think.

Harmless it might be, in the sense that it won't eat your data.

But it loses information, and I am not sure if it is worth it.  Why do you
even worry about "a few layers of quoting"?  Isn't it a much worse offense
from responder/commenter's part to quote and NOT trimming diffstat part?

 

  reply	other threads:[~2008-04-04  6:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-03 10:22 [PATCH] format-patch: set default stat_width to 72 Jeff King
2008-04-04  6:12 ` Junio C Hamano [this message]
2008-04-04 10:50   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr6dmywqg.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jengelh@computergmbh.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).