From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Tatsuki Sugiura <sugi@nemui.org>,
Gerrit Pape <pape@smarden.org>, Recai Oktas <roktas@debian.org>
Subject: Re: [PATCH] gitweb: Fix bug in insert_file() subroutine
Date: Mon, 08 Dec 2008 09:05:47 -0800 [thread overview]
Message-ID: <7vr64i7g2c.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081208130905.15803.83149.stgit@localhost.localdomain> (Jakub Narebski's message of "Mon, 08 Dec 2008 14:13:21 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> +# ----------------------------------------------------------------------
> +# non-ASCII in README.html
> +
> +test_expect_success \
> + 'README.html with non-ASCII characters (utf-8)' \
> + 'echo "<b>UTF-8 example:</b><br />" > .git/README.html &&
> + cat "$TEST_DIRECTORY"/t3900/1-UTF-8.txt >> .git/README.html &&
> + gitweb_run "p=.git;a=summary"'
> +test_debug 'cat gitweb.log'
> +
Yup, a new test would certainly help to catch breakages ;-)
Thanks.
prev parent reply other threads:[~2008-12-08 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 7:53 [PATCH] gitweb: fix encode handling for site_{header,footer} Tatsuki Sugiura
2008-11-17 10:28 ` Junio C Hamano
2008-11-17 10:40 ` Jakub Narebski
2008-12-01 18:01 ` [PATCH] gitweb: Fix handling of non-ASCII characters in inserted HTML files Jakub Narebski
2008-12-03 3:55 ` Junio C Hamano
2008-12-03 10:21 ` Jakub Narebski
2008-12-03 21:14 ` Junio C Hamano
2008-12-08 13:13 ` [PATCH] gitweb: Fix bug in insert_file() subroutine Jakub Narebski
2008-12-08 17:05 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr64i7g2c.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=pape@smarden.org \
--cc=roktas@debian.org \
--cc=sugi@nemui.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).