From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, Tay Ray Chuan <rctay89@gmail.com>
Subject: Re: [PATCH] smart-http: Don't use Expect: 100-Continue
Date: Tue, 15 Feb 2011 11:42:00 -0800 [thread overview]
Message-ID: <7vr5b9nkzb.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1297789044-17978-1-git-send-email-spearce@spearce.org> (Shawn O. Pearce's message of "Tue\, 15 Feb 2011 08\:57\:24 -0800")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> diff --git a/remote-curl.c b/remote-curl.c
> index 04d4813..3d82dc2 100644
> --- a/remote-curl.c
> +++ b/remote-curl.c
> @@ -356,14 +356,59 @@ static size_t rpc_in(const void *ptr, size_t eltsize,
> ...
> +static int probe_rpc(struct rpc_state *rpc)
> +{
> +...
> + curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
> + curl_easy_setopt(slot->curl, CURLOPT_FILE, buf);
> +
> + err = run_slot(slot);
> +
> + curl_slist_free_all(headers);
> + strbuf_release(&buf);
> + return err;
> +}
Hmm, I am getting
remote-curl.c:403: error: call to '_curl_easy_setopt_err_cb_data' declared
with attribute warning: curl_easy_setopt expects a private data pointer as
argument for this option
Shouldn't the above be giving a pointer to buf anyway?
remote-curl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/remote-curl.c b/remote-curl.c
index 297ecf7..256326a 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -400,7 +400,7 @@ static int probe_rpc(struct rpc_state *rpc)
curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE, 4);
curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, headers);
curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
- curl_easy_setopt(slot->curl, CURLOPT_FILE, buf);
+ curl_easy_setopt(slot->curl, CURLOPT_FILE, &buf);
err = run_slot(slot);
next prev parent reply other threads:[~2011-02-15 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 16:57 [PATCH] smart-http: Don't use Expect: 100-Continue Shawn O. Pearce
2011-02-15 19:42 ` Junio C Hamano [this message]
2011-02-15 23:54 ` Shawn Pearce
2011-02-16 7:38 ` Daniel Stenberg
2011-02-16 18:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5b9nkzb.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).