git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Peter Baumann <waste.manager@gmx.de>
Cc: Jeff King <peff@peff.net>,
	skillzero@gmail.com,
	Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: git rebase --continue automatic --skip?
Date: Sat, 09 Apr 2011 18:33:43 -0700	[thread overview]
Message-ID: <7vr59ayjns.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110409130309.GC30820@m62s10.vlinux.de> (Peter Baumann's message of "Sat, 9 Apr 2011 15:03:09 +0200")

Peter Baumann <waste.manager@gmx.de> writes:

> This was mentioned before on the list (sorry, don't have a reference, 
> but it was a long time ago). AFAIR the reason it wasn't implemented yet is that
> you will lose the commit message, which might contain precious information.

I don't recall ever seeing that justification; and I don't agree with it
either.  As far as the resulting history is concerned, that commit does
not even exist and there is no precious information.

This is a tangent, but I suspect that in the very old days, after a "git
rebase" stopped due to a conflict to have you adjust the change by
resolving conflicts, "git rebase --continue" may have offered you an
opportunity to edit the commit log message so that you can record what was
made unnecessary (or made additionally necessary) compared to the original
patch due to rebasing.  I don't offhand know when we lost that feature (it
is possible we never had anything like that and I am misremembering
things).

We may probably want to add it at least as an optional feature.  After
"git rebase" stops due to a conflict, and your resolution ends up to be
not an empty change, "git rebase --continue" seems to simply reuse the
original description these days.  It might be a good default, but in cases
where the conflict resolution made the change very different from the
original, the old log message may not describe why the change was needed
and how the change solved that issue properly in the context of the new
history.

"git commit -a -c .git/rebase-apply/original-commit" followed by "git
rebase --skip" is a workaround that is too ugly to be called "workable"
for it.  Perhaps "git rebase --edit --continue" or something?

  reply	other threads:[~2011-04-10  1:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 20:30 git rebase --continue automatic --skip? skillzero
2011-04-09  0:03 ` Jeff King
2011-04-09 13:03   ` Peter Baumann
2011-04-10  1:33     ` Junio C Hamano [this message]
2011-04-11  6:10     ` Peter Baumann
2011-04-10  1:24   ` Junio C Hamano
2011-04-13 19:02     ` Joshua Juran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr59ayjns.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=martin.von.zweigbergk@gmail.com \
    --cc=peff@peff.net \
    --cc=skillzero@gmail.com \
    --cc=waste.manager@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).