git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jared Hance <jaredhance@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Fix memory leak in apply_patch in apply.c.
Date: Wed, 07 Mar 2012 15:39:43 -0800	[thread overview]
Message-ID: <7vr4x4j800.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: eadfc83a0d823cc04ea37bf606b57597fb632156.1331158240.git.jaredhance@gmail.com

Jared Hance <jaredhance@gmail.com> writes:

> In the while loop inside apply_patch, patch is dynamically allocated
> with a calloc. However, only unused patches are actually free'd; the
> rest are left in a memory leak. Since a list is actively built up
> consisting of the used patches, they can simply be iterated and free'd
> at the end of the function.
> ...

Thanks.

This more-or-less looks good modulo minor style issues.  We might
also want to make rejected a one-bit bitfield that sits next to the
new free_patch field to share the same word, but that is a separate
topic.

Will queue.

  reply	other threads:[~2012-03-07 23:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07 22:21 [PATCH v3 0/3] Fix documented fixme's throughout Jared Hance
2012-03-07 22:21 ` [PATCH v3 1/3] Fix memory leak in apply_patch in apply.c Jared Hance
2012-03-07 23:39   ` Junio C Hamano [this message]
2012-03-21 22:18   ` [PATCH 1/2] apply: free patch->{def,old,new}_name fields Junio C Hamano
2012-03-21 22:21     ` [PATCH 2/2] apply: free patch->result Junio C Hamano
2012-03-07 22:21 ` [PATCH v3 2/3] Add threaded versions of functions in symlinks.c Jared Hance
2012-03-07 23:39   ` Junio C Hamano
2012-03-07 22:21 ` [PATCH v3 3/3] Use startup_info->prefix rather than prefix Jared Hance
2012-03-07 23:39   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4x4j800.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jaredhance@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).