From: Junio C Hamano <gitster@pobox.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] am: invoke perl's strftime in C locale
Date: Mon, 14 Jan 2013 13:49:06 -0800 [thread overview]
Message-ID: <7vr4ln8mgd.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130114205933.GA25947@altlinux.org> (Dmitry V. Levin's message of "Tue, 15 Jan 2013 00:59:33 +0400")
"Dmitry V. Levin" <ldv@altlinux.org> writes:
> This fixes "hg" patch format support for locales other than C and en_*,
> see https://bugzilla.altlinux.org/show_bug.cgi?id=28248
>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
Thanks.
The reference URL is not very friendly, and you should be able to
state it here on a single line in English instead, I think.
The patch looks correct, though.
> git-am.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-am.sh b/git-am.sh
> index c682d34..64b88e4 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -334,7 +334,7 @@ split_patches () {
> # Since we cannot guarantee that the commit message is in
> # git-friendly format, we put no Subject: line and just consume
> # all of the message as the body
> - perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }
> + LC_ALL=C perl -M'POSIX qw(strftime)' -ne 'BEGIN { $subject = 0 }
> if ($subject) { print ; }
> elsif (/^\# User /) { s/\# User/From:/ ; print ; }
> elsif (/^\# Date /) {
next prev parent reply other threads:[~2013-01-14 21:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 20:59 [PATCH] am: invoke perl's strftime in C locale Dmitry V. Levin
2013-01-14 21:49 ` Junio C Hamano [this message]
2013-01-14 22:36 ` [PATCH v2] " Dmitry V. Levin
2013-01-15 15:59 ` [PATCH] " Jeff King
2013-01-15 16:42 ` Antoine Pelisse
2013-01-15 16:50 ` Jeff King
2013-01-15 17:40 ` Dmitry V. Levin
2013-01-15 19:05 ` [PATCH v3] " Dmitry V. Levin
2013-01-18 20:36 ` Junio C Hamano
2013-01-19 16:39 ` Jeff King
2013-01-19 20:28 ` Dmitry V. Levin
2013-01-20 17:47 ` Junio C Hamano
2013-01-15 19:14 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4ln8mgd.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).