From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Nice error message for empty idents
Date: Sat, 18 Feb 2006 10:55:02 -0800 [thread overview]
Message-ID: <7vpslko5tl.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060218172731.GV31278@pasky.or.cz> (Petr Baudis's message of "Sat, 18 Feb 2006 18:27:31 +0100")
Petr Baudis <pasky@suse.cz> writes:
> $ git-rev-list --help
> fatal: Not a git repository
Hmph, true. Ideas?
> I agree that the error message itself is bad.
> - if (!*name || !*email)
> - die("empty ident %s <%s> not allowed",
> - name, email);
> + if (!*name)
> + die("empty realname not allowed - please set a realname for your login or use GIT_AUTHOR_NAME");
> + if (!*email)
> + die("empty email not allowed - please set your GIT_AUTHOR_EMAIL to a non-empty value");
I've considered doing this, but didn't do it that way, because I
could not figure out what to do with GIT_COMMITTER_NAME. Also
it might make sense to suggest user.name configuration item in
the error/help message. Ideas?
next prev parent reply other threads:[~2006-02-18 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 8:44 [RFC] empty ident? Junio C Hamano
2006-02-18 10:00 ` Nicolas Vilz 'niv'
2006-02-18 17:27 ` [PATCH] Nice error message for empty idents Petr Baudis
2006-02-18 18:55 ` Junio C Hamano [this message]
2006-02-19 4:56 ` [PATCH] Delay "empty ident" errors until they really matter Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpslko5tl.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).