From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Jan Engelhardt <jengelh@medozas.de>,
Lea Wiemann <lewiemann@gmail.com>
Subject: Re: [PATCH] gitweb: Add charset info to "raw" blob output
Date: Sat, 31 May 2008 11:22:00 -0700 [thread overview]
Message-ID: <7vprr2fi5z.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080531112513.30913.44393.stgit@localhost.localdomain> (Jakub Narebski's message of "Sat, 31 May 2008 13:27:01 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> Always add charset info from $default_text_plain_charset (if it is
> defined) to "raw" (a=blob_plain) output for 'text/plain' blobs.
> Adding charset info in a special case was removed from blob_mimetype().
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
Looks Ok but it took a bit of digging on the list for me to figure out
that something like this was missing from the beginning of your commit log
message:
Earlier "blob_plain" view sent "charset=utf-8" only when gitweb
guessed the content type to be text by reading from it, and not
when the MIME type was obtained from /etc/mime.types.
This fixes the bug by always adding....
But I wonder if moving of this to the calling site is the right thing to
do. Wouldn't it become much more contained and robust if you did it this
way?
gitweb/gitweb.perl | 34 +++++++++++++++++++---------------
1 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 57a1905..f5338e1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2471,29 +2471,33 @@ sub mimetype_guess {
sub blob_mimetype {
my $fd = shift;
my $filename = shift;
+ my $mime;
if ($filename) {
- my $mime = mimetype_guess($filename);
- $mime and return $mime;
- }
-
- # just in case
- return $default_blob_plain_mimetype unless $fd;
-
- if (-T $fd) {
- return 'text/plain' .
- ($default_text_plain_charset ? '; charset='.$default_text_plain_charset : '');
+ $mime = mimetype_guess($filename);
+ } else if (!defined $fd) {
+ $mime = $default_blob_plain_mimetype;
+ } else if (-T $fd) {
+ $mime = 'text/plain';
} elsif (! $filename) {
- return 'application/octet-stream';
+ $mime = 'application/octet-stream';
} elsif ($filename =~ m/\.png$/i) {
- return 'image/png';
+ $mime = 'image/png';
} elsif ($filename =~ m/\.gif$/i) {
- return 'image/gif';
+ $mime = 'image/gif';
} elsif ($filename =~ m/\.jpe?g$/i) {
- return 'image/jpeg';
+ $mime = 'image/jpeg';
} else {
- return 'application/octet-stream';
+ $mime = 'application/octet-stream';
}
+
+ # Type specific postprocessing can be added as needed...
+ if ($mime =~ /^text\//i &&
+ $mime !~ /charset=/i && $default_text_plain_charset) {
+ $mime .= '; charset='.$default_text_plain_charset;
+ }
+
+ return $mime;
}
## ======================================================================
next prev parent reply other threads:[~2008-05-31 18:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 18:04 gitweb forgets to send utf8 header for raw blob views Jan Engelhardt
2008-05-29 11:32 ` Lea Wiemann
2008-05-30 8:18 ` Jakub Narebski
2008-05-31 11:27 ` [PATCH] gitweb: Add charset info to "raw" blob output Jakub Narebski
2008-05-31 18:22 ` Junio C Hamano [this message]
2008-06-01 11:06 ` Jakub Narebski
2008-06-01 12:15 ` Jan Engelhardt
2008-06-01 12:16 ` Jan Engelhardt
2008-06-03 14:47 ` [PATCH v2] gitweb: Add charset info to "raw" output of 'text/plain' blobs Jakub Narebski
2008-05-31 15:04 ` gitweb forgets to send utf8 header for raw blob views Jan Engelhardt
2008-05-31 22:39 ` Jakub Narebski
2008-06-01 2:08 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprr2fi5z.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jengelh@medozas.de \
--cc=jnareb@gmail.com \
--cc=lewiemann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).