From: Junio C Hamano <gitster@pobox.com>
To: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
Cc: "David M. Syzdek" <david.syzdek@acsalaska.net>,
git@vger.kernel.org, jnareb@gmail.com
Subject: Re: [PATCH] autoconf: Add link tests to each AC_CHECK_FUNC() test
Date: Mon, 08 Jun 2009 22:30:20 -0700 [thread overview]
Message-ID: <7vprdet1n7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20090608212454.GA834@gmx.de
Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:
> Hello, and please forgive me for replying to a very old thread,
> <http://thread.gmane.org/gmane.comp.version-control.git/99159>.
> (BTW, is that frowned upon on this list?)
Not at all.
> * Junio C Hamano wrote on Sun, Nov 02, 2008 at 09:04:21AM CET:
>> "David M. Syzdek" <david.syzdek@acsalaska.net> writes:
>> > Update configure.ac to test libraries for getaddrinfo, strcasestr, memmem,
>> > strlcpy, strtoumax, setenv, unsetenv, and mkdtemp. The default compilers
>> > on FreeBSD 4.9-SECURITY and FreeBSD 6.2-RELEASE-p4 do not generate warnings
>> > for missing prototypes unless `-Wall' is used. This behavior renders the
>> > results of AC_CHECK_FUNC() void on these platforms. The test AC_SEARCH_LIBS()
>> > verifies a function is valid by linking to symbol within the system libraries.
>
> This description does not make sense. AC_CHECK_FUNC does not take into
> account prototypes in the test; instead, it tries to link a program that
> requires the function symbol.
Yeah, I just looked at output from AC_CHECK_FUNC(); it creates main() that
calls the function being checked and tries to see if the program links.
And SEARCH_LIBS() won't catch missing prototypes either.
> However, there might have been another reason altogether why David was
> seeing false configure test results on his system, and it would be
> interesting to know about them (both to possibly fix Autoconf, and the
> comment introducing GIT_CHECK_FUNC in configure.ac).
Yeah, I am interested, too. The closest BSD variant I happen to have
access to is FreeBSD 7.2, and reverting the commit there does not seem to
have any ill effects, so I'd like to know what breakage the patch fixed
(or covered up).
prev parent reply other threads:[~2009-06-09 5:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 11:52 [PATCH] autoconf: Add link tests to each AC_CHECK_FUNC() test David M. Syzdek
2008-11-02 8:04 ` Junio C Hamano
2009-06-08 21:24 ` Ralf Wildenhues
2009-06-09 5:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprdet1n7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Ralf.Wildenhues@gmx.de \
--cc=david.syzdek@acsalaska.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).