From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] t0006: test timezone parsing
Date: Tue, 06 Jul 2010 00:01:35 -0700 [thread overview]
Message-ID: <7vpqz13xgw.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100704104834.GA23070@sigill.intra.peff.net> (Jeff King's message of "Sun\, 4 Jul 2010 06\:48\:35 -0400")
Jeff King <peff@peff.net> writes:
> diff --git a/test-date.c b/test-date.c
> index a9e705f..ac6854a 100644
> --- a/test-date.c
> +++ b/test-date.c
> @@ -21,12 +21,15 @@ static void parse_dates(char **argv, struct timeval *now)
> for (; *argv; argv++) {
> char result[100];
> time_t t;
> + int tz;
>
> result[0] = 0;
> parse_date(*argv, result, sizeof(result));
> - t = strtoul(result, NULL, 0);
> - printf("%s -> %s\n", *argv,
> - t ? show_date(t, 0, DATE_ISO8601) : "bad");
> + if (sscanf(result, "%ld %d", &t, &tz) == 2)
Gah...
On FreeBSD 8.0, we now see this.
cc1: warnings being treated as errors
test-date.c: In function 'parse_dates':
test-date.c:28: warning: format '%ld' expects type 'long int *', but argument 3 has type 'time_t *'
next prev parent reply other threads:[~2010-07-06 7:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-04 10:48 [PATCH 1/2] t0006: test timezone parsing Jeff King
2010-07-04 11:00 ` [PATCH 2/2] parse_date: fix signedness in timezone calculation Jeff King
2010-07-06 2:35 ` Junio C Hamano
2010-07-06 23:34 ` [PATCH] t/t0006: specify timezone as EST5 not EST to comply with POSIX Brandon Casey
2010-07-07 9:48 ` Alex Riesen
2010-07-07 18:12 ` Jeff King
2010-07-07 22:59 ` Andreas Schwab
2010-07-06 7:01 ` Junio C Hamano [this message]
2010-07-06 7:28 ` [PATCH 1/2] t0006: test timezone parsing Jeff King
2010-07-06 7:54 ` Jeff King
2010-07-07 5:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpqz13xgw.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).