From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Thomas Rast <trast@student.ethz.ch>,
Jakub Narebski <jnareb@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 0/2] log/ format-patch improvements
Date: Wed, 25 Aug 2010 15:09:15 -0700 [thread overview]
Message-ID: <7vpqx6pcok.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100825084416.GC3280@kytes> (Ramkumar Ramachandra's message of "Wed\, 25 Aug 2010 14\:14\:21 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Ramkumar Ramachandra writes:
>> The first patch implements Jakub's suggestion. Arguably, it's slightly
>> complicated- it took me more than a few minutes to do the math with
>> `nr` and `nr_i`.
>>
>> The second patch clarifies the meaning of the `-<n>` option. We should
>> also probably force the mutual exclusivity of `-<n>` and <revision
>> range> to avoid confusion.
>>
>> Additionally, thanks to Thomas for drilling into me the fundamental
>> difference between -<n> and a revision range (on IRC).
>>
>> Ramkumar Ramachandra (2):
>> git-format-patch: Print a diagnostic message when ignoring commits
>> log: Improve description of '-<n>' option in documentation
>>
>> Documentation/git-format-patch.txt | 2 +-
>> Documentation/git-log.txt | 2 +-
>> builtin/log.c | 42 ++++++++++++++++++++++++++---------
>> 3 files changed, 33 insertions(+), 13 deletions(-)
>
> Do you see value in this patch or is it just unnecessary baggage?
I am not very impressed by the counting. It probably makes more sense to
count only what we are actually going to process and emit, i.e. always use
no-merges (do we even support format-patch on a merge?).
prev parent reply other threads:[~2010-08-25 22:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 20:28 [PATCH 0/2] log/ format-patch improvements Ramkumar Ramachandra
2010-08-21 20:28 ` [PATCH 1/2] git-format-patch: Print a diagnostic message when ignoring commits Ramkumar Ramachandra
2010-08-21 20:28 ` [PATCH 2/2] log: Improve description of '-<n>' option in documentation Ramkumar Ramachandra
2010-08-25 8:44 ` [PATCH 0/2] log/ format-patch improvements Ramkumar Ramachandra
2010-08-25 20:54 ` Jonathan Nieder
2010-08-26 5:34 ` Ramkumar Ramachandra
2010-08-26 5:46 ` Jonathan Nieder
2010-08-26 7:06 ` Thomas Rast
2010-08-26 15:37 ` Junio C Hamano
2010-08-26 17:52 ` Ramkumar Ramachandra
2010-08-25 22:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpqx6pcok.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).