From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Thomas Rast <trast@student.ethz.ch>, git@vger.kernel.org
Subject: Re: [PATCH] Make !pattern in .gitattributes non-fatal
Date: Sat, 02 Mar 2013 22:30:24 -0800 [thread overview]
Message-ID: <7vppzhc7wf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CACsJy8CO1i1_QpMbLvfys=wsLDPTK69_9JanQYq2D3-fboK_WA@mail.gmail.com> (Duy Nguyen's message of "Sat, 2 Mar 2013 10:50:14 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> This "return NULL;" means we ignore "!blah" pattern, which is a
> regression, isn't it? Should we treat '!' as literal here?
Probably not. Can you point to a project everybody has heard of
that keeps track of a path that begins with an exclamation point?
With clarification to the documentation that says "you cannot use !
to negate" and your "die on such an entry", we have been going in
the direction that forbids the use of such an entry, and making it
mean literal exclamation point is going sideways in the middle of
the road.
Besides, if you want to match a path that begins with an exclam, you
can always say "[!]", no?
next prev parent reply other threads:[~2013-03-03 6:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 20:06 [PATCH] Make !pattern in .gitattributes non-fatal Thomas Rast
2013-03-01 20:24 ` Junio C Hamano
2013-03-01 20:28 ` Junio C Hamano
2013-03-01 20:42 ` Thomas Rast
2013-03-01 21:53 ` Junio C Hamano
2013-03-02 3:50 ` Duy Nguyen
2013-03-03 6:30 ` Junio C Hamano [this message]
2013-03-02 4:18 ` [PATCH] attr: always treat the leading exclamation mark as literal Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vppzhc7wf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).