From: Junio C Hamano <gitster@pobox.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: git@vger.kernel.org,
"\=\?UTF-8\?q\?SZEDER\=20G\=C3\=A1bor\?\=" <szeder@ira.uka.de>
Subject: Re: [PATCH v2 2/2] send-email: add test for duplicate utf8 name
Date: Thu, 20 Jun 2013 12:20:34 -0700 [thread overview]
Message-ID: <7vppvgtwql.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1371731166-24015-2-git-send-email-mst@redhat.com
"Michael S. Tsirkin" <mst@redhat.com> writes:
> Verify that author name is not duplicated if it matches
> sender, even if it is in utf8.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
Hmph. There seems to be something wrong in the original message I
received from you (look at Cc: line I have above, which was copied
by my MUA from the message I am responding to).
Visiting
http://article.gmane.org/gmane.comp.version-control.git/228485/raw
shows this gem:
Cc: =?us-ascii?B?PT9VVEYtOD9xP1NaRURFUj0yMEc9QzM9QTFib3I/PQ==?=
<szeder@ira.uka.de>
Somebody is wrapping what "=?UTF-8?q?..." which you had already
wrapped into "=?us-ascii?B..."???
In any case, I think Thomas's "first expect failure and then flip
it, if you add test and fix as separate patches" is a good idea, and
the change between the previous one and this seems to be only the
last part of this test, so I'll tweak what I already have from the
previous on 'pu' locally and push the result out. Please double
check the result.
Thanks.
> t/t9001-send-email.sh | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 9f46f22..020acc4 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -956,6 +956,20 @@ test_expect_success $PREREQ 'utf8 author is correctly passed on' '
> grep "^From: Füñný Nâmé <odd_?=mail@example.com>" msgtxt1
> '
>
> +test_expect_success $PREREQ 'utf8 sender is not duplicated' '
> + clean_fake_sendmail &&
> + test_commit weird_sender &&
> + test_when_finished "git reset --hard HEAD^" &&
> + git commit --amend --author "Füñný Nâmé <odd_?=mail@example.com>" &&
> + git format-patch --stdout -1 >funny_name.patch &&
> + git send-email --from="Füñný Nâmé <odd_?=mail@example.com>" \
> + --to=nobody@example.com \
> + --smtp-server="$(pwd)/fake.sendmail" \
> + funny_name.patch &&
> + grep "^From:" msgtxt1 > msgfrom &&
> + test_line_count = 1 msgfrom
> +'
> +
> test_expect_success $PREREQ 'sendemail.composeencoding works' '
> clean_fake_sendmail &&
> git config sendemail.composeencoding iso-8859-1 &&
prev parent reply other threads:[~2013-06-20 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 12:27 [PATCH v2 1/2] send-email: sanitize author when writing From line Michael S. Tsirkin
2013-06-20 12:27 ` [PATCH v2 2/2] send-email: add test for duplicate utf8 name Michael S. Tsirkin
2013-06-20 12:41 ` Thomas Rast
2013-06-20 12:45 ` Michael S. Tsirkin
2013-06-20 12:48 ` Thomas Rast
2013-06-20 12:53 ` Michael S. Tsirkin
2013-06-20 19:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vppvgtwql.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mst@redhat.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).