From: Junio C Hamano <gitster@pobox.com>
To: John Szakmeister <john@szakmeister.net>
Cc: "Ramkumar Ramachandra" <artagnon@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Eduardo R. D'Avila" <erdavila@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH] prompt: do not double-discriminate detached HEAD
Date: Sun, 07 Jul 2013 10:53:03 -0700 [thread overview]
Message-ID: <7vppuu45q8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAEBDL5UfHpR3GNeqbDf9X3Ya+Spcpx0Byq5MZPMMsE=a3y2jhg@mail.gmail.com> (John Szakmeister's message of "Sun, 7 Jul 2013 09:35:29 -0400")
John Szakmeister <john@szakmeister.net> writes:
> On Sun, Jul 7, 2013 at 8:52 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
>> When GIT_PS1_SHOWCOLORHINTS is turned on, there is no need to put a
>> detached HEAD within parenthesis: the color can be used to discriminate
>> the detached HEAD.
>>
>> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>> ---
>> For cuteness :)
>
> Personally, I'd rather see the parens kept. Not everyone sees red
> very well--I know several people who can't see it at all, and it keeps
> it consistent with non-colored output.
+1; I find red on many terminal emulators to be too dark to tell,
especially in a small font, from black myself.
next prev parent reply other threads:[~2013-07-07 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 12:52 [PATCH] prompt: do not double-discriminate detached HEAD Ramkumar Ramachandra
2013-07-07 13:35 ` John Szakmeister
2013-07-07 17:53 ` Junio C Hamano [this message]
2013-07-07 18:32 ` Kyle McKay
2013-07-08 13:49 ` Ramkumar Ramachandra
2013-07-08 1:12 ` Eduardo R. D'Avila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vppuu45q8.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=erdavila@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@szakmeister.net \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).