From: Junio C Hamano <gitster@pobox.com>
To: Richard Hartmann <richih.mailinglist@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 6/6] template: Fix comment indentation in pre-rebase hook
Date: Mon, 10 Jun 2013 15:57:00 -0700 [thread overview]
Message-ID: <7vobbdefr7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAD77+gTv-x7ZKAR3PycDWNhqeWcnEFEhK290ndxeyqqkBfWfeQ@mail.gmail.com> (Richard Hartmann's message of "Mon, 10 Jun 2013 23:46:45 +0200")
Richard Hartmann <richih.mailinglist@gmail.com> writes:
> On Mon, Jun 10, 2013 at 9:52 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>
>> I think offsetting the actual commands to the right is correct, but
>> "if these match" and "if this is empty" should be flushed to left as
>> this patch shows.
>
> I actually considered this and decided against it as it seemed to be
> deliberate. Should I re-roll and re-send?
>
> I will gladly re-send the whole, or part of the, series once I know
> which patches are OK and which need more work.
[PATCH 1/6] templates: Fewer subprocesses in pre-commit hook
I agree with Peff that "less fork" is a bad justification for this
change, and also
echo 'First line
second line
third lie'
looks somewhat bad.
[PATCH 2/6] templates: Reformat pre-commit hook's message
I think it is a good thing to make the output short by widening.
[PATCH 3/6] templates: Fix spelling in pre-commit hook
Good.
[PATCH 4/6] Documentation: Update manpage for pre-commit hook
I debated myself if it should say "The hook _by default_ prevents
addition of non-ASCII filenames", hinting that it can be
configured out if it is unwanted.
Other than that, I think it is a good addition.
[PATCH 5/6] templates: Fix ASCII art in pre-rebase hook
Good, but see Peff's comments on the explanation.
[PATCH 6/6] template: Fix comment indentation in pre-rebase hook
After reading the original once again, it is fine as-is without
the change at all, I think. Alternatively, "if these match" and
"if this is empty" lines can be flushed to the left, which also is
readable.
Thanks.
next prev parent reply other threads:[~2013-06-10 22:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 18:35 [PATCH 0/4] Janitorial work on hook templates Richard Hartmann
2013-06-10 18:36 ` [PATCH 1/6] templates: Fewer subprocesses in pre-commit hook Richard Hartmann
2013-06-10 19:44 ` Junio C Hamano
2013-06-10 20:39 ` Richard Hartmann
2013-06-10 21:25 ` Jeff King
2013-06-10 18:36 ` [PATCH 2/6] templates: Reformat pre-commit hook's message Richard Hartmann
2013-06-10 19:47 ` Junio C Hamano
2013-06-10 18:36 ` [PATCH 3/6] templates: Fix spelling in pre-commit hook Richard Hartmann
2013-06-10 18:36 ` [PATCH 4/6] Documentation: Update manpage for " Richard Hartmann
2013-06-10 18:36 ` [PATCH 5/6] templates: Fix ASCII art in pre-rebase hook Richard Hartmann
2013-06-10 19:51 ` Junio C Hamano
2013-06-10 21:29 ` Jeff King
2013-06-10 18:36 ` [PATCH 6/6] template: Fix comment indentation " Richard Hartmann
2013-06-10 19:52 ` Junio C Hamano
2013-06-10 21:46 ` Richard Hartmann
2013-06-10 22:57 ` Junio C Hamano [this message]
2013-06-10 23:03 ` Richard Hartmann
2013-07-14 16:21 ` [PATCH 0/6] Update to janitorial work on hook templates Richard Hartmann
2013-07-14 16:21 ` [PATCH 1/6] templates: Use heredoc in pre-commit hook Richard Hartmann
2013-07-14 18:09 ` Jonathan Nieder
2013-07-15 3:22 ` Junio C Hamano
2013-07-14 19:20 ` Junio C Hamano
2013-07-14 20:12 ` Richard Hartmann
2013-07-14 20:20 ` Jonathan Nieder
2013-07-15 16:49 ` Junio C Hamano
2013-07-14 16:21 ` [PATCH 2/6] templates: Reformat pre-commit hook's message Richard Hartmann
2013-07-14 18:42 ` Jonathan Nieder
2013-07-14 16:21 ` [PATCH 3/6] templates: Fix spelling in pre-commit hook Richard Hartmann
2013-07-14 16:21 ` [PATCH 4/6] Documentation: Update manpage for " Richard Hartmann
2013-07-14 18:51 ` Jonathan Nieder
2013-07-15 16:54 ` Junio C Hamano
2013-07-14 16:21 ` [PATCH 5/6] templates: Fix ASCII art in pre-rebase hook Richard Hartmann
2013-07-14 18:52 ` Jonathan Nieder
2013-07-14 16:21 ` [PATCH 6/6] template: Fix comment indentation " Richard Hartmann
2013-07-14 18:53 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vobbdefr7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=richih.mailinglist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).