From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: git@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: format-patch on permission change gives empty patch
Date: Thu, 07 Oct 2010 13:29:29 -0700 [thread overview]
Message-ID: <7vmxqpwxue.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1010071503210.3107@xanadu.home> (Nicolas Pitre's message of "Thu\, 07 Oct 2010 15\:06\:05 -0400 \(EDT\)")
Nicolas Pitre <nico@fluxnic.net> writes:
> On Wed, 6 Oct 2010, Junio C Hamano wrote:
>
>> I have a mixed feeling about where to go next.
>>
>> (1) Treat "rebase" as a way to reproduce a reasonable history; the
>> current behaviour to drop empty commits is consistent with this view,
>> as a history with an empty commit is _not_ entirely reasonable.
>
> But a file mode change isn't exactly an empty commit, no?
The second message from DaveM:
Message-ID: <20101006.174008.70175671.davem@davemloft.net>
Ok it turns out that the commit in question was a NOP since the file
permissions didn't change.
prev parent reply other threads:[~2010-10-07 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 0:37 format-patch on permission change gives empty patch David Miller
2010-10-07 0:40 ` David Miller
2010-10-07 4:13 ` Junio C Hamano
2010-10-07 4:40 ` Junio C Hamano
2010-10-07 8:15 ` Sverre Rabbelier
2010-10-07 10:05 ` Jakub Narebski
2010-10-07 10:12 ` Sverre Rabbelier
2010-10-07 19:06 ` Nicolas Pitre
2010-10-07 20:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmxqpwxue.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davem@davemloft.net \
--cc=git@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).