From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH] Makefile: dependencies for vcs-svn tests
Date: Tue, 12 Oct 2010 16:22:08 -0700 [thread overview]
Message-ID: <7vmxqjngin.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20101010055032.GA23100@burratino> (Jonathan Nieder's message of "Sun\, 10 Oct 2010 00\:50\:32 -0500")
Jonathan Nieder <jrnieder@gmail.com> writes:
> The vcs-svn tests (test-treap.o et al) depend on the vcs-svn
> headers for declarations and inline functions. Declare the
> dependency. While at it, declare a dependency of the vcs-svn
> objects (vcs-svn/string_pool.o et al) on $(LIB_H) to reflect use
> within the vcs-svn library of git-compat-util.h and cache.h.
Thanks.
>
> Makefile | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index d3dcfb1..1bd1823 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1762,6 +1762,8 @@ XDIFF_OBJS = xdiff/xdiffi.o xdiff/xprepare.o xdiff/xutils.o xdiff/xemit.o \
> xdiff/xmerge.o xdiff/xpatience.o
> VCSSVN_OBJS = vcs-svn/string_pool.o vcs-svn/line_buffer.o \
> vcs-svn/repo_tree.o vcs-svn/fast_export.o vcs-svn/svndump.o
> +VCSSVN_TEST_OBJS = test-obj-pool.o test-string-pool.o \
> + test-line-buffer.o test-treap.o
> OBJECTS := $(GIT_OBJS) $(XDIFF_OBJS) $(VCSSVN_OBJS)
>
> dep_files := $(foreach f,$(OBJECTS),$(dir $f).depend/$(notdir $f).d)
> @@ -1885,10 +1887,12 @@ xdiff-interface.o $(XDIFF_OBJS): \
> xdiff/xinclude.h xdiff/xmacros.h xdiff/xdiff.h xdiff/xtypes.h \
> xdiff/xutils.h xdiff/xprepare.h xdiff/xdiffi.h xdiff/xemit.h
>
> -$(VCSSVN_OBJS): \
> +$(VCSSVN_OBJS) $(VCSSVN_TEST_OBJS): $(LIB_H) \
> vcs-svn/obj_pool.h vcs-svn/trp.h vcs-svn/string_pool.h \
> vcs-svn/line_buffer.h vcs-svn/repo_tree.h vcs-svn/fast_export.h \
> vcs-svn/svndump.h
> +
> +test-svn-fe.o: vcs-svn/svndump.h
> endif
>
> exec_cmd.s exec_cmd.o: EXTRA_CPPFLAGS = \
> --
> 1.7.2.3
next prev parent reply other threads:[~2010-10-12 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 5:50 [PATCH] Makefile: dependencies for vcs-svn tests Jonathan Nieder
2010-10-12 23:22 ` Junio C Hamano [this message]
2010-12-04 19:23 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmxqjngin.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).