From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Jeff King <peff@peff.net>, Johannes Sixt <j6t@kdbg.org>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] Fix some sparse warnings
Date: Sun, 21 Jul 2013 13:58:58 -0700 [thread overview]
Message-ID: <7vmwpfsk8d.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130721173936.GA10647@elie.Belkin> (Jonathan Nieder's message of "Sun, 21 Jul 2013 10:39:37 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> How about something like the following?
>
> diff --git i/cache.h w/cache.h
> index f2915509..ba028b75 100644
> --- i/cache.h
> +++ w/cache.h
> @@ -1124,6 +1124,7 @@ struct object_info {
> } packed;
> } u;
> };
> +#define OBJECT_INFO_INIT { NULL, NULL, OI_CACHED, { { NULL, 0, 0 } } }
There are quite a many hits from
$ git grep '= { *NULL *};'
only some of which are "char *var[] = { NULL }", which is perfectly
fine, but others are to initialise "struct foo" (or "foo_t" which is
typedef'ed) that share the same "writing NULL means the initialiser
knows the order of the fields".
I doubt if the above #define is a maintainable solution, and worse
yet, thinking about the fact that such a macro is necessary only for
a structure whose first field happens to be of a pointer type, it
strongly suggests me that it is not conceptually the right thing to
do.
Can't we have sparse fixed (or skip this specific warning) instead?
next prev parent reply other threads:[~2013-07-21 20:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 20:25 [PATCH] Fix some sparse warnings Ramsay Jones
2013-07-18 20:36 ` Jeff King
2013-07-20 19:26 ` Ramsay Jones
2013-07-21 17:39 ` Jonathan Nieder
2013-07-21 20:58 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-07-15 17:31 Ramsay Jones
2013-07-16 5:57 ` Johannes Sixt
2013-07-16 6:21 ` Jeff King
2013-07-16 20:53 ` Philip Oakley
2013-07-16 21:18 ` Stefan Beller
2013-07-16 22:18 ` Philip Oakley
2013-07-17 5:47 ` Johannes Sixt
2013-07-17 22:08 ` Stefan Beller
2013-07-17 22:16 ` Stefan Beller
2013-07-17 23:22 ` Junio C Hamano
2013-07-18 17:58 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmwpfsk8d.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).