From: Junio C Hamano <junkio@cox.net>
To: Ryan Anderson <ryan@michonline.com>
Cc: git@vger.kernel.org, Martin Langhoff <martin.langhoff@gmail.com>
Subject: Re: [PATCH 0/2] Update git-send-email-script with --compose
Date: Mon, 05 Sep 2005 11:46:25 -0700 [thread overview]
Message-ID: <7vll2b4ake.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20050905153705.GD5335@mythryan2.michonline.com> (Ryan Anderson's message of "Mon, 5 Sep 2005 11:37:05 -0400")
Ryan Anderson <ryan@michonline.com> writes:
> On Mon, Sep 05, 2005 at 11:16:57PM +1200, Martin Langhoff wrote:
>>
>> - reads "subject" from the first line of STDIN or file. If the line
>> doesn't start with [PATCH it provides the [PATCH] prefix. I found it
>> really confusing that it wants to get 'from' in the first line...
>> that's not what git-format-patch produces!
>
> Sorry about that - I always export using git-format-patch using --mbox,
> and those work nicely. I'm a bit reluctant to do the [PATCH] fixup, but
> I think I will:
>
> 1. Detect [PATCH] or [PATCH [0-9]+/[0-9]+] (Sorry for the horrid
> fake-regexp)
> 2. Provide a --no-fixup-subject to turn that off.
>
> (TODO #2)
To be consistent with the other tools in tools/ directory, the
above is probably 's/^/[PATCH] / unless (/^\[PATCH/])'
> In this case, remember that this was an attempt to help users patch bomb
> lists, getting all the subtle details correct. The prompting is there
> to help get the subtle details correct!
You could error out without asking if that is what is happening.
> Well, I'm not. Try "git format-patch --mbox -o patchdir origin" and see
> if that works better for you.
Martin, --mbox has the added benefit that it consistently
preserves the From: and Date: information even for your own
patches, because it implies --date and --author. By default
without --author and --date these are not preserved from the
original commits for your own patches, primarily because
format-patch without --mbox was written for reorganizing and
reordering existing patches (i.e. export, concatenate some, edit
some hunks, and eventually feed it to applymbox to make commits;
you do not typically want to keep the original author date for
this kind of use).
> I do apologize for not realizing that the default git format-patch
> output doesn't match what git send-email script expects the "legacy"
> mode - I'll sort that out one way or another as well. (TODO #3)
I do apologize for not really saying what --mbox does and what
the format-patch output without --mbox is meant for.
Martin, is there a reason you do not want --mbox format
(e.g. format-patch --mbox spits out Subject: line undesirably
formatted while it does what you want without --mbox)?
next prev parent reply other threads:[~2005-09-05 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-05 5:13 [PATCH 0/2] Update git-send-email-script with --compose Ryan Anderson
2005-09-05 5:13 ` [PATCH 1/2] Make git-send-email-script ignore some unnecessary options when operating in batch mode Ryan Anderson
2005-09-05 5:13 ` [PATCH 2/2] Update documentation of --compose to git-send-email-script.txt Ryan Anderson
2005-09-05 11:16 ` [PATCH 0/2] Update git-send-email-script with --compose Martin Langhoff
2005-09-05 15:37 ` Ryan Anderson
2005-09-05 18:46 ` Junio C Hamano [this message]
2005-09-05 20:06 ` Martin Langhoff
2005-09-05 20:38 ` Junio C Hamano
2005-09-05 20:45 ` Martin Langhoff
2005-09-05 21:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vll2b4ake.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=martin.langhoff@gmail.com \
--cc=ryan@michonline.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).