* [PATCH] gitk: add check for required tcl version >= 8.4
2007-09-27 17:00 Relating to some syntax error in the gitk script Brett Schwarz
@ 2007-09-28 20:57 ` Steffen Prohaska
0 siblings, 0 replies; 3+ messages in thread
From: Steffen Prohaska @ 2007-09-28 20:57 UTC (permalink / raw
To: git; +Cc: Steffen Prohaska
gitk requires tcl version >= 8.4 to work flawlessly. So let's
check the tcl version and quit if it's too low.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---
gitk | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 300fdce..6ea6489 100755
--- a/gitk
+++ b/gitk
@@ -7,6 +7,11 @@ exec wish "$0" -- "$@"
# and distributed under the terms of the GNU General Public Licence,
# either version 2, or (at your option) any later version.
+if {[info tclversion] < 8.4} {
+ puts stderr "Sorry, gitk requires tcl version >= 8.4."
+ exit 1
+}
+
proc gitdir {} {
global env
if {[info exists env(GIT_DIR)]} {
--
1.5.3.2.111.g5166
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] gitk: add check for required tcl version >= 8.4
@ 2007-09-29 9:32 Junio C Hamano
2007-10-20 11:19 ` Paul Mackerras
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2007-09-29 9:32 UTC (permalink / raw
To: paulus; +Cc: git, Steffen Prohaska
From: Steffen Prohaska <prohaska@zib.de>
Date: Fri, 28 Sep 2007 22:57:22 +0200
gitk requires tcl version >= 8.4 to work flawlessly. So let's
check the tcl version and quit if it's too low.
Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---
* I do not have a ready access to older tcl/tk myself, so I
cannot judge if this is sensible or not. Just forwarding in
case you missed it.
gitk | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 300fdce..6ea6489 100755
--- a/gitk
+++ b/gitk
@@ -7,6 +7,11 @@ exec wish "$0" -- "$@"
# and distributed under the terms of the GNU General Public Licence,
# either version 2, or (at your option) any later version.
+if {[info tclversion] < 8.4} {
+ puts stderr "Sorry, gitk requires tcl version >= 8.4."
+ exit 1
+}
+
proc gitdir {} {
global env
if {[info exists env(GIT_DIR)]} {
--
1.5.3.2.111.g5166
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitk: add check for required tcl version >= 8.4
2007-09-29 9:32 [PATCH] gitk: add check for required tcl version >= 8.4 Junio C Hamano
@ 2007-10-20 11:19 ` Paul Mackerras
0 siblings, 0 replies; 3+ messages in thread
From: Paul Mackerras @ 2007-10-20 11:19 UTC (permalink / raw
To: Junio C Hamano; +Cc: git, Steffen Prohaska
Junio C Hamano writes:
> From: Steffen Prohaska <prohaska@zib.de>
> Date: Fri, 28 Sep 2007 22:57:22 +0200
>
> gitk requires tcl version >= 8.4 to work flawlessly. So let's
> check the tcl version and quit if it's too low.
>
> Signed-off-by: Steffen Prohaska <prohaska@zib.de>
> ---
>
> * I do not have a ready access to older tcl/tk myself, so I
> cannot judge if this is sensible or not. Just forwarding in
> case you missed it.
Thanks for the patch. I have put in something similar using the
package require command, and using show_error to display the error in
a window.
Paul.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-20 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-29 9:32 [PATCH] gitk: add check for required tcl version >= 8.4 Junio C Hamano
2007-10-20 11:19 ` Paul Mackerras
-- strict thread matches above, loose matches on Subject: below --
2007-09-27 17:00 Relating to some syntax error in the gitk script Brett Schwarz
2007-09-28 20:57 ` [PATCH] gitk: add check for required tcl version >= 8.4 Steffen Prohaska
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).