From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
"Felipe Contreras" <felipec@infradead.org>,
git@vger.kernel.org, "Lee Marlow" <lee.marlow@gmail.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v2 4/4] completion: be nicer with zsh
Date: Mon, 30 Jan 2012 11:09:47 -0800 [thread overview]
Message-ID: <7vliopatxg.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120130182547.GA22549@burratino> (Jonathan Nieder's message of "Mon, 30 Jan 2012 12:25:47 -0600")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Felipe Contreras wrote:
>
>> The commands might fail, that's why '2> /dev/null' was used before,
>> and ':' is used right now.
>
> Wait, what?
>
> : is a no-op command. It does not redirect stderr automatically or
> do any other magical thing.
s/no-op/true/ ;-)
> ..., so I suppose consistency is the only reason to
> prefer one over another.
Yes. And the script may probably use [[ very heavily.
Early return after || i.e.
A || return
B
simply looks ugly and misleading, especially when the remainder B is just
a single line. But I stopped caring about the styles in this particular
script long time ago, so...
next prev parent reply other threads:[~2012-01-30 19:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 17:23 [PATCH 0/4] completion: trivial cleanups Felipe Contreras
2012-01-30 17:23 ` [PATCH v2 2/4] completion: remove unused code Felipe Contreras
[not found] ` <1327944197-6379-2-git-send-email-felipec@infradead.org>
2012-01-30 17:34 ` [PATCH v2 1/4] completion: simplify __git_remotes Jonathan Nieder
2012-01-30 18:27 ` Junio C Hamano
[not found] ` <1327944197-6379-4-git-send-email-felipec@infradead.org>
2012-01-30 17:50 ` [PATCH v2 3/4] completion: cleanup __gitcomp* Jonathan Nieder
2012-01-30 19:03 ` Junio C Hamano
2012-01-30 21:25 ` Junio C Hamano
2012-01-31 0:15 ` SZEDER Gábor
2012-01-31 0:25 ` Jonathan Nieder
[not found] ` <1327944197-6379-5-git-send-email-felipec@infradead.org>
2012-01-30 17:53 ` [PATCH v2 4/4] completion: be nicer with zsh Jonathan Nieder
2012-01-30 18:10 ` Felipe Contreras
2012-01-30 18:25 ` Jonathan Nieder
2012-01-30 18:56 ` Felipe Contreras
2012-01-30 19:03 ` Jonathan Nieder
2012-01-30 19:09 ` Junio C Hamano [this message]
2012-01-30 19:22 ` Felipe Contreras
2012-01-30 19:28 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vliopatxg.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=felipec@infradead.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=lee.marlow@gmail.com \
--cc=spearce@spearce.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).