git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ben Walton <bdwalton@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability
Date: Mon, 08 Oct 2012 09:35:27 -0700	[thread overview]
Message-ID: <7vlifgncq8.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1349683681-18978-1-git-send-email-bdwalton@gmail.com> (Ben Walton's message of "Mon, 8 Oct 2012 09:08:01 +0100")

Ben Walton <bdwalton@gmail.com> writes:

> Avoid a GNU-ism in the cp options used by t5400-send-pack.  Change -a
> to -pR.
>
> Signed-off-by: Ben Walton <bdwalton@gmail.com>
> ---

Thanks, but is "-p" essential for this test to pass, or can we get
away with just "-R"?

>  t/t5400-send-pack.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh
> index 250c720..65b3b0f 100755
> --- a/t/t5400-send-pack.sh
> +++ b/t/t5400-send-pack.sh
> @@ -159,7 +159,7 @@ test_expect_success 'receive-pack runs auto-gc in remote repo' '
>  	    git commit -a -m "Second commit" &&
>  	    git repack
>  	) &&
> -	cp -a parent child &&
> +	cp -pR parent child &&
>  	(
>  	    # Set the child to auto-pack if more than one pack exists
>  	    cd child &&

  reply	other threads:[~2012-10-08 16:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08  8:08 [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability Ben Walton
2012-10-08 16:35 ` Junio C Hamano [this message]
2012-10-08 16:55   ` Junio C Hamano
2012-10-08 17:45     ` Junio C Hamano
2012-10-08 20:05       ` Ben Walton
2012-10-08 21:19         ` Junio C Hamano
2012-10-09  7:15     ` Joachim Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vlifgncq8.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=bdwalton@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).