git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jesper L. Nielsen" <lyager@gmail.com>
Cc: git@vger.kernel.org, "David A. Greene" <greened@obbligato.org>
Subject: Re: [PATCH] For git-subtree, when installing docs (make install-doc), create man1 folder first.
Date: Sat, 15 Dec 2012 10:07:02 -0800	[thread overview]
Message-ID: <7vlicztcjd.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1355429376-4192-1-git-send-email-lyager@gmail.com> (Jesper L. Nielsen's message of "Thu, 13 Dec 2012 21:09:36 +0100")

"Jesper L. Nielsen" <lyager@gmail.com> writes:

> From: "Jesper L. Nielsen" <lyager@gmail.com>
>
> Hi..
>
> I installed Git subtree and discovered that the if the man1dir doesn't exist the man-page for Git Subtree is just called man1.
>
> So, small patch to create the folder first in the Makefile. Hope everything is right with the patch and submitting of the patch.
>
> Best Regards
> Jesper
>
> Signed-off-by: Jesper L. Nielsen <lyager@gmail.com>
> ---
>  contrib/subtree/Makefile | 1 +
>  1 file changed, 1 insertion(+)

This is a good first step in the right direction, I think.

Shouldn't the install targets take DESTDIR into account like the
main Makefile does, though?

As to the patch submission, everything below "---" line looks sane,
but please check how others write commit log messages by browsing a
handful of entries in "git log --no-merges" output and notice the
difference (the details are found in Documentation/SubmittingPatches).

Thanks.

> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
> index 05cdd5c..a341cf4 100644
> --- a/contrib/subtree/Makefile
> +++ b/contrib/subtree/Makefile
> @@ -35,6 +35,7 @@ install: $(GIT_SUBTREE)
>  install-doc: install-man
>  
>  install-man: $(GIT_SUBTREE_DOC)
> +	mkdir -p $(man1dir)
>  	$(INSTALL) -m 644 $^ $(man1dir)
>  
>  $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)

  reply	other threads:[~2012-12-15 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13 20:09 [PATCH] For git-subtree, when installing docs (make install-doc), create man1 folder first Jesper L. Nielsen
2012-12-15 18:07 ` Junio C Hamano [this message]
     [not found] ` <7v8v91y97f.fsf@alter.siamese.dyndns.org>
2013-01-01  3:01   ` greened
2013-01-01  3:06 ` greened

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vlicztcjd.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=greened@obbligato.org \
    --cc=lyager@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).