From: Junio C Hamano <gitster@pobox.com>
To: Mathieu Lienard--Mayor <Mathieu.Lienard--Mayor@ensimag.imag.fr>
Cc: git@vger.kernel.org,
Jorge Juan Garcia Garcia
<Jorge-Juan.Garcia-Garcia@ensimag.imag.fr>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v4 1/2] rm: better error message on failure for multiple files
Date: Tue, 11 Jun 2013 11:07:41 -0700 [thread overview]
Message-ID: <7vli6gbjwy.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1370962561-12519-1-git-send-email-Mathieu.Lienard--Mayor@ensimag.imag.fr> (Mathieu Lienard--Mayor's message of "Tue, 11 Jun 2013 16:56:00 +0200")
Mathieu Lienard--Mayor <Mathieu.Lienard--Mayor@ensimag.imag.fr>
writes:
> +static void print_error_files(struct string_list *files_list,
> + const char *main_msg,
> + const char *hints_msg,
> + int *errs)
> +{
> + if (files_list->nr) {
> + struct strbuf err_msg = STRBUF_INIT;
> + int i;
> + strbuf_addstr(&err_msg, main_msg);
> + for (i = 0; i < files_list->nr; i++)
> + strbuf_addf(&err_msg,
> + "\n %s",
> + files_list->items[i].string);
> + strbuf_addstr(&err_msg, hints_msg);
> + *errs = error("%s", err_msg.buf);
> + strbuf_release(&err_msg);
> + }
> +}
> +
> static int check_submodules_use_gitfiles(void)
> {
> int i;
> int errs = 0;
>
> + struct string_list files = STRING_LIST_INIT_NODUP;
> +
> for (i = 0; i < list.nr; i++) {
The blank after the initialization lines before the first statement
is very much welcom, but please drop the blank line before this new
initialization, i.e.
int i;
int errs = 0;
struct string_list files = STRING_LIST_INIT_NODUP;
for (i = 0; i < list.nr; i++) {
...
> @@ -61,11 +82,17 @@ static int check_submodules_use_gitfiles(void)
> continue;
>
> if (!submodule_uses_gitfile(name))
> + string_list_append(&files, name);
> }
> + print_error_files(&files,
> + Q_("the following submodule (or one of its nested "
> + "submodules)\n uses a .git directory:",
> + "the following submodules (or one of its nested "
> + "submodules)\n use a .git directory:",
> + files.nr),
> + _("\n(use 'rm -rf' if you really want to remove "
> + "it including all of its history)"),
> + &errs);
>
> return errs;
No string_list_clear() on files?
> }
> @@ -82,6 +109,11 @@ static int check_local_mod(unsigned char *head, int index_only)
> int i, no_head;
> int errs = 0;
>
> + struct string_list files_staged = STRING_LIST_INIT_NODUP;
> + struct string_list files_cached = STRING_LIST_INIT_NODUP;
> + struct string_list files_submodule = STRING_LIST_INIT_NODUP;
> + struct string_list files_local = STRING_LIST_INIT_NODUP;
> +
> ...
> + print_error_files(&files_local,
> + Q_("the following file has local modifications:",
> + "the following files have local modifications:",
> + files_local.nr),
> + _("\n(use --cached to keep the file,"
> + " or -f to force removal)"),
> + &errs);
> +
No string_list_clear() on files_*?
prev parent reply other threads:[~2013-06-11 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 14:56 [PATCH v4 1/2] rm: better error message on failure for multiple files Mathieu Lienard--Mayor
2013-06-11 14:56 ` [PATCH v4 2/2] rm: introduce advice.rmHints to shorten messages Mathieu Lienard--Mayor
2013-06-11 16:35 ` Matthieu Moy
2013-06-11 18:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vli6gbjwy.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
--cc=Mathieu.Lienard--Mayor@ensimag.imag.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).