* [PATCH] add NO_CURL option to the Makefile
@ 2005-07-31 0:14 Johannes Schindelin
2005-07-31 1:09 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schindelin @ 2005-07-31 0:14 UTC (permalink / raw
To: git
This patch implements Linus' idea that if you are not interested in
pulling by HTTP, you can now say
NO_CURL=1 make
to compile everything except git-http-pull (thus not needing curl at all).
---
Makefile | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
b2e1e7eb6876b5f385bc52bf78e9551d1457215b
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -69,7 +69,7 @@ PROG= git-update-cache git-diff-files
git-checkout-cache git-diff-tree git-rev-tree git-ls-files \
git-check-files git-ls-tree git-merge-base git-merge-cache \
git-unpack-file git-export git-diff-cache git-convert-cache \
- git-http-pull git-ssh-push git-ssh-pull git-rev-list git-mktag \
+ git-ssh-push git-ssh-pull git-rev-list git-mktag \
git-diff-helper git-tar-tree git-local-pull git-hash-object \
git-get-tar-commit-id git-apply git-stripspace \
git-diff-stages git-rev-parse git-patch-id git-pack-objects \
@@ -78,6 +78,10 @@ PROG= git-update-cache git-diff-files
git-show-index git-daemon git-var git-peek-remote \
git-update-server-info git-show-rev-cache git-build-rev-cache
+ifndef NO_CURL
+PROG+= git-http-pull
+endif
+
LIB_FILE=libgit.a
LIB_H=cache.h object.h blob.h tree.h commit.h tag.h delta.h epoch.h csum-file.h \
pack.h pkt-line.h refs.h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] add NO_CURL option to the Makefile
2005-07-31 0:14 [PATCH] add NO_CURL option to the Makefile Johannes Schindelin
@ 2005-07-31 1:09 ` Junio C Hamano
2005-07-31 4:12 ` Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2005-07-31 1:09 UTC (permalink / raw
To: Johannes Schindelin; +Cc: git
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> This patch implements Linus' idea that if you are not interested in
> pulling by HTTP, you can now say
>
> NO_CURL=1 make
>
> to compile everything except git-http-pull (thus not needing curl at all).
Thanks. Obviously this does not take care of the use of curl
executable to handle http:// URL in clone and fetch, but I do
not think that is worth the trouble (we should document it
though).
I love it I can just slow down and let others submit obviously
correct patches, which I can just slurp in.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] add NO_CURL option to the Makefile
2005-07-31 1:09 ` Junio C Hamano
@ 2005-07-31 4:12 ` Linus Torvalds
0 siblings, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2005-07-31 4:12 UTC (permalink / raw
To: Junio C Hamano; +Cc: Johannes Schindelin, git
On Sat, 30 Jul 2005, Junio C Hamano wrote:
>
> I love it I can just slow down and let others submit obviously
> correct patches, which I can just slurp in.
You're obviously doing well as a maintainer. Only stupid people try to do
everything themselves.
Personally, I spend a _lot_ of time communicating, because even if it's a
lot more work to explain (in detail) what I want done, and it doesn't work
out all the time, and I sometimes have to do it myself _anyway_, if it
works even just occasionally, it not only gets people involved, it makes
them do it themselves next time around without prodding, and then you just
sit back, sip a foofy tropical drink, and take the credit.
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-07-31 4:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-31 0:14 [PATCH] add NO_CURL option to the Makefile Johannes Schindelin
2005-07-31 1:09 ` Junio C Hamano
2005-07-31 4:12 ` Linus Torvalds
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).