From: Junio C Hamano <junkio@cox.net>
To: Christian Biesinger <cbiesinger@web.de>
Cc: git@vger.kernel.org, Ryan Anderson <ryan@michonline.com>,
Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: [PATCH] Don't send copies to the From: address
Date: Fri, 10 Feb 2006 19:55:13 -0800 [thread overview]
Message-ID: <7vk6c2sg66.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 11396260373307-git-send-email-cbiesinger@web.de
Christian Biesinger <cbiesinger@web.de> writes:
> Sending copies to the from address is pointless.
Ryan, care to defend this part of the code? This behaviour
might have been inherited from Greg's original version.
I cannot speak for Ryan or Greg, but I think the script
deliberately does this to support this workflow:
(1) The original author sends in a patch to a subsystem
maintainer;
(2) The subsystem maintainer applies the patch to her tree,
perhaps with her own sign-off and sign-offs by other people
collected from the list. She examines it and says this
patch is good;
(3) The commit is formatted and sent to higher level of the
foodchain. The message is CC'ed to interested parties in
order to notify that the patch progressed in the
foodchain.
Me, personally I do not like CC: to people on the signed-off-by
list, but dropping a note to From: person makes perfect sense to
me, if it is to notify the progress of the patch.
What you are after _might_ be not CC'ing it if it was your own
patch. Maybe something like this would help, but even if that
is the case I suspect many people want to CC herself so it needs
to be an optional feature.
-- >8 --
[PATCH] Do not CC me
---
git diff
diff --git a/git-send-email.perl b/git-send-email.perl
index 3f1b3ca..a02e2f8 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -343,7 +343,7 @@ foreach my $t (@files) {
}
close F;
- $cc = join(", ", unique_email_list(@cc));
+ $cc = join(", ", unique_email_list(grep { $_ ne $from } @cc));
send_message();
next prev parent reply other threads:[~2006-02-11 3:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 2:47 [PATCH] Don't send copies to the From: address Christian Biesinger
2006-02-11 3:55 ` Junio C Hamano [this message]
2006-02-11 4:52 ` Greg KH
2006-02-11 12:33 ` Christian Biesinger
2006-02-11 12:31 ` Christian Biesinger
2006-02-13 7:20 ` Ryan Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk6c2sg66.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=cbiesinger@web.de \
--cc=git@vger.kernel.org \
--cc=greg@kroah.com \
--cc=ryan@michonline.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).