From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] rev-list --bisect: Move finding bisection into do_find_bisection.
Date: Sun, 16 Sep 2007 01:47:13 -0700 [thread overview]
Message-ID: <7vk5qr575a.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20070915125957.0899841b.chriscool@tuxfamily.org> (Christian Couder's message of "Sat, 15 Sep 2007 12:59:57 +0200")
Christian Couder <chriscool@tuxfamily.org> writes:
> This factorises some code and make a big function smaller.
I think the refactoring itself makes sense, especially where it
simplifies the clean-up of weight array in early-return
codepath. But I have a couple of comments, though.
> +static struct commit_list *do_find_bisection(struct commit_list *list,
> + int nr, int *weights);
> +
> /*
> * zero or positive weight is the number of interesting commits it can
> * reach, including itself. Especially, weight = 0 means it does not
The comment whose top part we can see here talks about the magic
values -1 and -2 used while do_find_bisection() after the
refactoring does its work, and these magic values are never
visible to the calling function. You should move the comment to
the top of do_find_bisection() as well.
Also this forward declaration is unwarranted. A bottom-up
sequence to define do_find_bisection() first, then to define its
sole caller find_bisection() next is easier to read at least for
me.
The latter comment also applies to your other patch.
next prev parent reply other threads:[~2007-09-16 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 10:59 [PATCH 1/3] rev-list --bisect: Move finding bisection into do_find_bisection Christian Couder
2007-09-16 8:47 ` Junio C Hamano [this message]
2007-09-17 3:19 ` Christian Couder
-- strict thread matches above, loose matches on Subject: below --
2007-09-17 3:28 Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5qr575a.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).