From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] Improved and extended t5404
Date: Wed, 14 Nov 2007 00:47:48 -0800 [thread overview]
Message-ID: <7vk5olkybv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071114071929.GA2942@steel.home> (Alex Riesen's message of "Wed, 14 Nov 2007 08:19:29 +0100")
Alex Riesen <raa.lkml@gmail.com> writes:
> Junio C Hamano, Wed, Nov 14, 2007 01:02:20 +0100:
>> Alex Riesen <raa.lkml@gmail.com> writes:
>>
>> > Ignore exit code of git push in t5404, as it is not relevant for the
>> > test
>>
>> This proposed log message solicits a "Huh? -- Since when
>> ignoring exit code is an improvement?" reaction. If this push
>> is expected to error out, then wouldn't you want to make sure it
>> errors out as expected? If the problem is that the exit status
>> is unreliable, maybe we need to make it reliable instead?
>
> Well, it is kind of undefined. git push just updated some remote
> references and failed on the others. It has had some failures, so it
> returns non-0. And as I said, it really is not about the operation,
> but about if the tracking and remote branches are set as we want them.
Ok, I guess the proposed log message was not clear enough, at
least for me.
Will apply.
next prev parent reply other threads:[~2007-11-14 8:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 21:38 [PATCH] Add a test checking if send-pack updated local tracking branches correctly Alex Riesen
2007-11-12 21:39 ` [PATCH] Update the tracking references only if they were succesfully updated on remote Alex Riesen
2007-11-13 7:52 ` Jeff King
2007-11-13 19:47 ` Alex Riesen
2007-11-13 19:49 ` [PATCH] Add a test for deleting remote branches Alex Riesen
2007-11-13 23:02 ` [PATCH] Improved and extended t5404 Alex Riesen
2007-11-13 23:10 ` Jeff King
2007-11-15 4:26 ` Jeff King
2007-11-15 20:46 ` [PATCH] Add test that checks diverse aspects of updating remote and tracking branches Alex Riesen
2007-11-14 0:02 ` [PATCH] Improved and extended t5404 Junio C Hamano
2007-11-14 7:19 ` Alex Riesen
2007-11-14 8:47 ` Junio C Hamano [this message]
2007-11-14 17:10 ` Johannes Schindelin
2007-11-14 19:45 ` Alex Riesen
2007-11-14 20:34 ` Alex Riesen
2007-11-14 22:01 ` Johannes Schindelin
2007-11-15 4:18 ` Jeff King
2007-11-15 4:35 ` Jeff King
2007-11-15 5:55 ` Junio C Hamano
2007-11-14 21:52 ` Junio C Hamano
2007-11-14 22:49 ` [PATCH] Add test that checks diverse aspects of updating remote and tracking branches Alex Riesen
2007-11-14 21:52 ` [PATCH] Improved and extended t5404 Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5olkybv.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).