git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Whit Armstrong <armstrong.whit@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/3] solaris test results
Date: Wed, 20 Feb 2008 16:34:25 -0800	[thread overview]
Message-ID: <7vk5kz171q.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080220235944.GA6278@coredump.intra.peff.net> (Jeff King's message of "Wed, 20 Feb 2008 18:59:44 -0500")

Jeff King <peff@peff.net> writes:

>   - Sun's diff doesn't understand "-u". I was able to use GNU diff.
>     Since comparing actual and expected output is so common, we could
>     potentially abstract this with a "test_cmp()" function and use
>     something platform specific. It's probably not worth the trouble, as
>     it impacts only the test suite, and only on systems with a totally
>     broken diff.

It is unfair to call diff without -u "totally broken".  It is
not even in POSIX yet IIRC.

>   - t7505 uses a hook which hard-codes /bin/sh but uses syntax that
>     the Solaris /bin/sh doesn't like. Maybe hooks should get their
>     $SHELL value replaced?

You've already did that in your [PATCH 2/3], haven't you?  So
why not?

  parent reply	other threads:[~2008-02-21  0:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 23:59 [PATCH 0/3] solaris test results Jeff King
2008-02-21  0:00 ` [PATCH 1/3] git_config_*: don't assume we are parsing a config file Jeff King
2008-02-21  0:00 ` [PATCH 2/3] t3404: use configured shell instead of /bin/sh Jeff King
2008-02-23 20:13   ` Johannes Sixt
2008-02-23 20:26     ` Junio C Hamano
2008-02-23 20:34     ` Junio C Hamano
2008-02-23 21:09       ` Johannes Sixt
2008-02-23 21:15         ` Jeff King
2008-02-23 21:56           ` Junio C Hamano
2008-02-23 22:39             ` Jeff King
2008-02-23 22:46               ` Junio C Hamano
2008-02-23 22:49                 ` Jeff King
2008-02-23 22:55                   ` Junio C Hamano
2008-02-23 23:12                     ` Jeff King
2008-02-24  0:03                       ` Junio C Hamano
2008-02-24 19:40                         ` Jeff King
2008-02-23 20:40     ` Jeff King
2008-02-23 20:50       ` Junio C Hamano
2008-02-23 21:12         ` Jeff King
2008-02-23 22:28           ` Jeff King
2008-02-23 22:35             ` Junio C Hamano
2008-02-23 22:44               ` Jeff King
2008-02-21  0:01 ` [PATCH 3/3] diff: fix java funcname pattern for solaris Jeff King
2008-02-21  0:34 ` Junio C Hamano [this message]
2008-02-21  0:41   ` [PATCH 0/3] solaris test results Jeff King
2008-02-22  5:26     ` Junio C Hamano
2008-02-22  5:29       ` Junio C Hamano
2008-02-22  5:42       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk5kz171q.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=armstrong.whit@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).