git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org, kraai@ftbfs.org
Subject: Re: [PATCH] tests: turn on test-lint-shell-syntax by default
Date: Tue, 15 Jan 2013 12:38:44 -0800	[thread overview]
Message-ID: <7vk3re2ncb.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <50F5B83E.9060800@web.de> ("Torsten Bögershausen"'s message of "Tue, 15 Jan 2013 21:12:46 +0100")

Torsten Bögershausen <tboegi@web.de> writes:

> What do we think about something like this for fishing for which:
>
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -644,6 +644,10 @@ yes () {
>                 :
>         done
>  }
> +which () {
> +       echo >&2 "which is not portable (please use type)"
> +       exit 1
> +}
>
>
> This will happen in runtime, which might be good enough ?

	if (
		which frotz &&
                test $(frobonitz --version" -le 2.0
	   )
        then
		test_set_prereq FROTZ_FROBONITZ
	else
		echo >&2 "suitable Frotz/Frobonitz combo not available;"
                echo >&2 "some tests may be skipped"
	fi

I somehow think this is a lost cause.

  reply	other threads:[~2013-01-15 20:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-12  5:50 [PATCH] tests: turn on test-lint-shell-syntax by default Torsten Bögershausen
2013-01-12  6:00 ` Junio C Hamano
2013-01-13 10:25   ` Torsten Bögershausen
2013-01-13 16:50     ` Matt Kraai
2013-01-13 17:32     ` Jonathan Nieder
2013-01-13 22:38       ` Junio C Hamano
2013-01-15 20:12         ` Torsten Bögershausen
2013-01-15 20:38           ` Junio C Hamano [this message]
2013-01-26  6:57             ` Torsten Bögershausen
2013-01-26 21:43               ` Junio C Hamano
2013-01-27  7:43                 ` Torsten Bögershausen
2013-01-27  9:31               ` Jonathan Nieder
2013-01-27 13:13                 ` Torsten Bögershausen
2013-01-27 17:34                   ` Junio C Hamano
2013-01-27 20:25                     ` Junio C Hamano
2013-02-05 20:36                     ` Torsten Bögershausen
2013-02-05 20:52                       ` Junio C Hamano
2013-02-05 21:56                         ` Junio C Hamano
2013-01-27 17:15                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk3re2ncb.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=kraai@ftbfs.org \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).