From: Junio C Hamano <gitster@pobox.com> To: benoit.person@ensimag.fr Cc: git@vger.kernel.org, Celestin Matte <celestin.matte@ensimag.fr>, Matthieu Moy <matthieu.moy@grenoble-inp.fr> Subject: Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable Date: Tue, 02 Jul 2013 16:01:15 -0700 [thread overview] Message-ID: <7vk3l8in2c.fsf@alter.siamese.dyndns.org> (raw) In-Reply-To: <1372804789-12732-3-git-send-email-benoit.person@ensimag.fr> (benoit person's message of "Wed, 3 Jul 2013 00:39:44 +0200") benoit.person@ensimag.fr writes: > From: Benoit Person <benoit.person@ensimag.fr> > > For now, bin-wrappers (based on wrap-for-bin.sh) redefine some > environnement variables (like $GITPERLLIB). If we want to chain to > those scripts and define one of those variables before, our changes > will be overwritten. > > This patch simply makes the bin-wrappers prepend their modifications > rather than redefine the vars. > > Signed-off-by: Benoit Person <benoit.person@ensimag.fr> > Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr> > --- > wrap-for-bin.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh > index 53a8dd0..dbebe49 100644 > --- a/wrap-for-bin.sh > +++ b/wrap-for-bin.sh > @@ -14,7 +14,7 @@ else > GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt' > export GIT_TEMPLATE_DIR > fi > -GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib' > +GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib:'"$GITPERLLIB" Do we want to add that ':' unconditionally? Could GITPERLLIB be empty? > GIT_TEXTDOMAINDIR='@@BUILD_DIR@@/po/build/locale' > PATH='@@BUILD_DIR@@/bin-wrappers:'"$PATH" > export GIT_EXEC_PATH GITPERLLIB PATH GIT_TEXTDOMAINDIR
next prev parent reply other threads:[~2013-07-02 23:01 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-02 22:39 [PATCH v7 0/7] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person 2013-07-02 22:39 ` [PATCH v7 1/7] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person 2013-07-02 22:59 ` Junio C Hamano 2013-07-02 22:39 ` [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable benoit.person 2013-07-02 23:01 ` Junio C Hamano [this message] 2013-07-02 23:19 ` Benoît Person 2013-07-03 8:54 ` Junio C Hamano 2013-07-03 9:46 ` Benoît Person 2013-07-03 10:30 ` Michael Haggerty 2013-07-03 10:57 ` Matthieu Moy 2013-07-03 20:24 ` Junio C Hamano 2013-07-03 20:38 ` Matthieu Moy 2013-07-03 21:50 ` Junio C Hamano 2013-07-02 22:39 ` [PATCH v7 3/7] git-remote-mediawiki: New git bin-wrapper for developement benoit.person 2013-07-02 23:04 ` Junio C Hamano 2013-07-02 22:39 ` [PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper benoit.person 2013-07-03 9:18 ` Matthieu Moy 2013-07-02 22:39 ` [PATCH v7 5/7] git-remote-mediawiki: Factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person 2013-07-02 22:39 ` [PATCH v7 6/7] git-remote-mediawiki: Adding git-mw command benoit.person 2013-07-02 22:39 ` [PATCH v7 7/7] git-remote-mediawiki: Add preview subcommand into git mw benoit.person
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7vk3l8in2c.fsf@alter.siamese.dyndns.org \ --to=gitster@pobox.com \ --cc=benoit.person@ensimag.fr \ --cc=celestin.matte@ensimag.fr \ --cc=git@vger.kernel.org \ --cc=matthieu.moy@grenoble-inp.fr \ --subject='Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).