From: Junio C Hamano <gitster@pobox.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/6] t/send-email.sh: add test for suppress self
Date: Wed, 29 May 2013 15:59:51 -0700 [thread overview]
Message-ID: <7vip21qtnc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vmwrdqu9f.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 29 May 2013 15:46:36 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>> If we don't want to use \, this can also be done like this:
>>
>> FOO << EOF &&
>> BLABLA
>> EOF
>> BAR &&
>> VAR
>>
>> I think this is what you suggest.
>
> Yup, that is exactly what I meant (but no leading indentation before
> BAR and VAR).
>
> That way, it is a lot more clear where the input is (the BLABLA is
> fed to FOO and BAR and VAR do not have anything to do with it).
>
>>> > + grep '^Cc:' msghdr1-$3 > actual-no-cc-$3 && \
>>> > + test_cmp expected-no-cc-$3 actual-no-cc-$3
>
> OK, so this is where the message begins, with the commit title "test
> supress-cc.self...".
Another thing I forgot to say, if you are rerolling this patch
anyway to follow that style, is that our newer tests typically
write it like this:
test_supress_self () {
test_commit $3 &&
test_when_finished "git reset --hard HEAD^" &&
write_script <<-EOF &&
sed -n -e s/^cccmd--//p \"\$1\"
EOF
git commit --amend --author="$1 <$2>" -F - <<-EOF &&
test suppress-cc.self $3 with name $1 email $2
$3
cccmd--"$1" <$2>
Cc: "$1" <$2>
Cc: $1 <$2>
Signed-off-by: "$1" <$2>
Signed-off-by: $1 <$2>
EOF
clean_fake_sendmail &&
git format-patch --stdout -1 >"suppress-self-$3.patch" &&
git send-email --from="$1 <$2>" \
--to=nobody@example.com \
... other args ...
... verification steps for the send-email output ...
}
next prev parent reply other threads:[~2013-05-29 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 14:40 [PATCH 0/6] git send-email suppress-cc=self fixes Michael S. Tsirkin
2013-05-26 14:40 ` [PATCH 1/6] t/send-email.sh: add test for suppress self Michael S. Tsirkin
2013-05-29 20:28 ` Junio C Hamano
2013-05-29 21:44 ` Michael S. Tsirkin
2013-05-29 22:46 ` Junio C Hamano
2013-05-29 22:59 ` Junio C Hamano [this message]
2013-05-30 4:51 ` Michael S. Tsirkin
2013-05-26 14:40 ` [PATCH 2/6] send-email: fix suppress-cc=self on cccmd Michael S. Tsirkin
2013-05-26 14:41 ` [PATCH 3/6] t/send-email: test " Michael S. Tsirkin
2013-05-26 14:41 ` [PATCH 4/6] send-email: make --suppress-cc=self sanitize input Michael S. Tsirkin
2013-05-26 14:41 ` [PATCH 5/6] t/send-email: add test with quoted sender Michael S. Tsirkin
2013-05-26 14:41 ` [PATCH 6/6] t/send-email: test suppress-cc=self with non-ascii Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vip21qtnc.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).