From: Junio C Hamano <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: Matt Kraai <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH 3/3] wt-status: use "format" function attribute for status_printf Date: Tue, 09 Jul 2013 22:35:25 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20130710052859.GA5339@sigill.intra.peff.net> (Jeff King's message of "Wed, 10 Jul 2013 01:28:59 -0400") Jeff King <email@example.com> writes: > On Tue, Jul 09, 2013 at 10:26:04PM -0700, Junio C Hamano wrote: > >> Jeff King <firstname.lastname@example.org> writes: >> >> > These functions could benefit from the added compile-time >> > safety of having the compiler check printf arguments. >> > >> > Unfortunately, we also sometimes pass an empty format string, >> > which will cause false positives with -Wformat-zero-length. >> > In this case, that warning is wrong because our function is >> > not a no-op with an empty format: it may be printing >> > colorized output along with a trailing newline. >> > >> > Signed-off-by: Jeff King <email@example.com> >> > --- >> > I'm torn on this one. It really does provide us with more compile-time >> > safety checks, but it's annoying that "-Wall -Werror" will no longer >> > work out of the box. >> >> Yeah, that is a show-stopper for me X-<. > > You can "fix" it with -Wno-zero-format-length, so the hassle is not > huge. Yes, or just do func(..., "%s", "") perhaps? That also sound iffy. > But I am also inclined to just drop this one. We have lived > without the extra safety for a long time, and list review does tend to > catch such problems in practice. > > -Peff
next prev parent reply other threads:[~2013-07-10 5:35 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-09 5:18 [PATCH] remote-http: use argv-array Junio C Hamano 2013-07-09 6:05 ` Bert Wesarg 2013-07-09 6:38 ` Jeff King 2013-07-09 22:27 ` Matt Kraai 2013-07-10 0:16 ` Jeff King 2013-07-10 0:18 ` [PATCH 1/3] add missing "format" function attributes Jeff King 2013-07-10 0:19 ` [PATCH 2/3] use "sentinel" function attribute for variadic lists Jeff King 2013-07-10 0:23 ` [PATCH 3/3] wt-status: use "format" function attribute for status_printf Jeff King 2013-07-10 5:26 ` Junio C Hamano 2013-07-10 5:28 ` Jeff King 2013-07-10 5:35 ` Junio C Hamano [this message] 2013-07-10 5:40 ` Jeff King 2013-07-10 5:52 ` Junio C Hamano 2013-07-10 6:11 ` Jeff King 2013-07-10 6:17 ` Junio C Hamano 2013-07-12 16:10 ` Junio C Hamano 2013-07-12 20:44 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 3/3] wt-status: use "format" function attribute for status_printf' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).