* [ANNOUNCE] git/gitweb.git repository @ 2007-08-31 0:01 Petr Baudis 2007-08-31 0:56 ` David Symonds ` (4 more replies) 0 siblings, 5 replies; 24+ messages in thread From: Petr Baudis @ 2007-08-31 0:01 UTC (permalink / raw) To: git; +Cc: jnareb, ltuikov Hi, due to popular (Junio's) demand, I have set up a gitweb-oriented fork of git at repo.or.cz: http://repo.or.cz/w/git/gitweb.git It is meant as a hub for various gitweb-related patches and development efforts. So far it is pre-seeded by the patches repo.or.cz's gitweb uses. It is divided to three main branches (StGIT patchstacks in reality), where master is what Junio is gonna pull to git's master. Please feel encouraged to make random forks for your development efforts, or push your random patches (preferrably just bugfixes, something possibly controversial should be kept in safe containment like a fork or separate branch) to the mob branch. Have fun, -- Petr "Pasky" Baudis Early to rise and early to bed makes a male healthy and wealthy and dead. -- James Thurber ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-08-31 0:01 [ANNOUNCE] git/gitweb.git repository Petr Baudis @ 2007-08-31 0:56 ` David Symonds 2007-08-31 1:00 ` David Symonds 2007-09-01 5:46 ` David Symonds 2007-09-01 1:06 ` Luben Tuikov ` (3 subsequent siblings) 4 siblings, 2 replies; 24+ messages in thread From: David Symonds @ 2007-08-31 0:56 UTC (permalink / raw) To: Petr Baudis; +Cc: git, jnareb, ltuikov On 31/08/2007, Petr Baudis <pasky@suse.cz> wrote: > Please feel encouraged to make random forks for your development > efforts, or push your random patches (preferrably just bugfixes, > something possibly controversial should be kept in safe containment like > a fork or separate branch) to the mob branch. Sorry, I'm still relatively new to git, and couldn't work out how to push to the mob branch, so it's inline below. It's fairly minor, just adding <span title="foo">..</span> around author names when they get abbreviated. Dave. >From 37c85462393d3e83d83dbdc9362cd9ff7587574c Mon Sep 17 00:00:00 2001 From: David Symonds <dsymonds@gmail.com> Date: Fri, 31 Aug 2007 10:49:53 +1000 Subject: [PATCH] gitweb: Provide title attributes for abbreviated author names. Signed-off-by: David Symonds <dsymonds@gmail.com> --- gitweb/gitweb.perl | 34 +++++++++++++++++++++++++++++----- 1 files changed, 29 insertions(+), 5 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index b2bae1b..3112fd4 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3461,9 +3461,15 @@ sub git_shortlog_body { print "<tr class=\"light\">\n"; } $alternate ^= 1; + my $author = chop_str($co{'author_name'}, 10); + if ($author ne $co{'author_name'}) { + $author = "<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>"; + } else { + $author = esc_html($author); + } # git_summary() used print "<td><i>$co{'age_string'}</i></td>\n" . print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 10)) . "</i></td>\n" . + "<td><i>" . $author . "</i></td>\n" . "<td>"; print format_subject_html($co{'title'}, $co{'title_short'}, href(action=>"commit", hash=>$commit), $ref); @@ -3511,9 +3517,15 @@ sub git_history_body { print "<tr class=\"light\">\n"; } $alternate ^= 1; + # shortlog uses chop_str($co{'author_name'}, 10) + my $author = chop_str($co{'author_name'}, 15, 3); + if ($author ne $co{'author_name'}) { + "<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>"; + } else { + $author = esc_html($author); + } print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - # shortlog uses chop_str($co{'author_name'}, 10) - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 3)) . "</i></td>\n" . + "<td><i>" . $author . "</i></td>\n" . "<td>"; # originally git_history used chop_str($co{'title'}, 50) print format_subject_html($co{'title'}, $co{'title_short'}, @@ -3667,8 +3679,14 @@ sub git_search_grep_body { print "<tr class=\"light\">\n"; } $alternate ^= 1; + my $author = chop_str($co{'author_name'}, 15, 5); + if ($author ne $co{'author_name'}) { + $author = "<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>"; + } else { + $author = esc_html($author); + } print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" . + "<td><i>" . $author . "</i></td>\n" . "<td>" . $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list subject"}, esc_html(chop_str($co{'title'}, 50)) . "<br/>"); @@ -5181,8 +5199,14 @@ sub git_search { print "<tr class=\"light\">\n"; } $alternate ^= 1; + my $author = chop_str($co{'author_name'}, 15, 5); + if ($author ne $co{'author_name'}) { + $author = "<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>"; + } else { + $author = esc_html($author); + } print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" . + "<td><i>" . $author . "</i></td>\n" . "<td>" . $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list subject"}, -- 1.5.2.4 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-08-31 0:56 ` David Symonds @ 2007-08-31 1:00 ` David Symonds 2007-09-01 5:46 ` David Symonds 1 sibling, 0 replies; 24+ messages in thread From: David Symonds @ 2007-08-31 1:00 UTC (permalink / raw) To: Petr Baudis; +Cc: git, jnareb, ltuikov On 31/08/2007, David Symonds <dsymonds@gmail.com> wrote: > On 31/08/2007, Petr Baudis <pasky@suse.cz> wrote: > > Please feel encouraged to make random forks for your development > > efforts, or push your random patches (preferrably just bugfixes, > > something possibly controversial should be kept in safe containment like > > a fork or separate branch) to the mob branch. > > Sorry, I'm still relatively new to git, and couldn't work out how to > push to the mob branch, so it's inline below. It's fairly minor, just > adding <span title="foo">..</span> around author names when they get > abbreviated. Darn, looks like I suck at copy-n-paste, too. Here's an unwrapped patch: >From 37c85462393d3e83d83dbdc9362cd9ff7587574c Mon Sep 17 00:00:00 2001 From: David Symonds <dsymonds@gmail.com> Date: Fri, 31 Aug 2007 10:49:53 +1000 Subject: [PATCH] gitweb: Provide title attributes for abbreviated author names. Signed-off-by: David Symonds <dsymonds@gmail.com> --- gitweb/gitweb.perl | 34 +++++++++++++++++++++++++++++----- 1 files changed, 29 insertions(+), 5 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index b2bae1b..3112fd4 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3461,9 +3461,15 @@ sub git_shortlog_body { print "<tr class=\"light\">\n"; } $alternate ^= 1; + my $author = chop_str($co{'author_name'}, 10); + if ($author ne $co{'author_name'}) { + $author = "<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>"; + } else { + $author = esc_html($author); + } # git_summary() used print "<td><i>$co{'age_string'}</i></td>\n" . print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 10)) . "</i></td>\n" . + "<td><i>" . $author . "</i></td>\n" . "<td>"; print format_subject_html($co{'title'}, $co{'title_short'}, href(action=>"commit", hash=>$commit), $ref); @@ -3511,9 +3517,15 @@ sub git_history_body { print "<tr class=\"light\">\n"; } $alternate ^= 1; + # shortlog uses chop_str($co{'author_name'}, 10) + my $author = chop_str($co{'author_name'}, 15, 3); + if ($author ne $co{'author_name'}) { + "<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>"; + } else { + $author = esc_html($author); + } print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - # shortlog uses chop_str($co{'author_name'}, 10) - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 3)) . "</i></td>\n" . + "<td><i>" . $author . "</i></td>\n" . "<td>"; # originally git_history used chop_str($co{'title'}, 50) print format_subject_html($co{'title'}, $co{'title_short'}, @@ -3667,8 +3679,14 @@ sub git_search_grep_body { print "<tr class=\"light\">\n"; } $alternate ^= 1; + my $author = chop_str($co{'author_name'}, 15, 5); + if ($author ne $co{'author_name'}) { + $author = "<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>"; + } else { + $author = esc_html($author); + } print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" . + "<td><i>" . $author . "</i></td>\n" . "<td>" . $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list subject"}, esc_html(chop_str($co{'title'}, 50)) . "<br/>"); @@ -5181,8 +5199,14 @@ sub git_search { print "<tr class=\"light\">\n"; } $alternate ^= 1; + my $author = chop_str($co{'author_name'}, 15, 5); + if ($author ne $co{'author_name'}) { + $author = "<span title=\"$co{'author_name'}\">" . esc_html($author) . "</span>"; + } else { + $author = esc_html($author); + } print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" . - "<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" . + "<td><i>" . $author . "</i></td>\n" . "<td>" . $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list subject"}, -- 1.5.2.4 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-08-31 0:56 ` David Symonds 2007-08-31 1:00 ` David Symonds @ 2007-09-01 5:46 ` David Symonds 2007-09-07 6:39 ` David Symonds 1 sibling, 1 reply; 24+ messages in thread From: David Symonds @ 2007-09-01 5:46 UTC (permalink / raw) To: Petr Baudis; +Cc: git, jnareb, ltuikov On 31/08/07, David Symonds <dsymonds@gmail.com> wrote: > On 31/08/2007, Petr Baudis <pasky@suse.cz> wrote: > > Please feel encouraged to make random forks for your development > > efforts, or push your random patches (preferrably just bugfixes, > > something possibly controversial should be kept in safe containment like > > a fork or separate branch) to the mob branch. > > Sorry, I'm still relatively new to git, and couldn't work out how to > push to the mob branch, so it's inline below. It's fairly minor, just > adding <span title="foo">..</span> around author names when they get > abbreviated. Okay, I worked out how to push to the mob branch: it's commit 37c8546. I can refactor this somewhat if that's an issue. Dave. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 5:46 ` David Symonds @ 2007-09-07 6:39 ` David Symonds 0 siblings, 0 replies; 24+ messages in thread From: David Symonds @ 2007-09-07 6:39 UTC (permalink / raw) To: Petr Baudis; +Cc: git, jnareb, ltuikov On 01/09/2007, David Symonds <dsymonds@gmail.com> wrote: > On 31/08/07, David Symonds <dsymonds@gmail.com> wrote: > > On 31/08/2007, Petr Baudis <pasky@suse.cz> wrote: > > > Please feel encouraged to make random forks for your development > > > efforts, or push your random patches (preferrably just bugfixes, > > > something possibly controversial should be kept in safe containment like > > > a fork or separate branch) to the mob branch. > > > > Sorry, I'm still relatively new to git, and couldn't work out how to > > push to the mob branch, so it's inline below. It's fairly minor, just > > adding <span title="foo">..</span> around author names when they get > > abbreviated. > > Okay, I worked out how to push to the mob branch: it's commit 37c8546. > I can refactor this somewhat if that's an issue. Has anyone taken a look at this? If it's bad/unwanted, just tell me and I'll drop it. Dave. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-08-31 0:01 [ANNOUNCE] git/gitweb.git repository Petr Baudis 2007-08-31 0:56 ` David Symonds @ 2007-09-01 1:06 ` Luben Tuikov 2007-09-01 1:16 ` Petr Baudis 2007-09-01 1:25 ` Johannes Schindelin 2007-09-01 15:15 ` Jon Smirl ` (2 subsequent siblings) 4 siblings, 2 replies; 24+ messages in thread From: Luben Tuikov @ 2007-09-01 1:06 UTC (permalink / raw) To: Petr Baudis, git; +Cc: jnareb, ltuikov --- Petr Baudis <pasky@suse.cz> wrote: > Hi, > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork > of git at repo.or.cz: > > http://repo.or.cz/w/git/gitweb.git > > It is meant as a hub for various gitweb-related patches and > development efforts. So far it is pre-seeded by the patches repo.or.cz's > gitweb uses. Is this right? So what's the review process now? "Because it is part of repo.or.cz's gitweb" seems to be a weak argument. Luben > It is divided to three main branches (StGIT patchstacks in > reality), where master is what Junio is gonna pull to git's master. > > Please feel encouraged to make random forks for your development > efforts, or push your random patches (preferrably just bugfixes, > something possibly controversial should be kept in safe containment like > a fork or separate branch) to the mob branch. > > Have fun, > > -- > Petr "Pasky" Baudis > Early to rise and early to bed makes a male healthy and wealthy and dead. > -- James Thurber > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 1:06 ` Luben Tuikov @ 2007-09-01 1:16 ` Petr Baudis 2007-09-01 1:23 ` Luben Tuikov 2007-09-01 1:25 ` Johannes Schindelin 1 sibling, 1 reply; 24+ messages in thread From: Petr Baudis @ 2007-09-01 1:16 UTC (permalink / raw) To: Luben Tuikov; +Cc: git, jnareb On Sat, Sep 01, 2007 at 03:06:02AM CEST, Luben Tuikov wrote: > --- Petr Baudis <pasky@suse.cz> wrote: > > Hi, > > > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork > > of git at repo.or.cz: > > > > http://repo.or.cz/w/git/gitweb.git > > > > It is meant as a hub for various gitweb-related patches and > > development efforts. So far it is pre-seeded by the patches repo.or.cz's > > gitweb uses. > > Is this right? > > So what's the review process now? "Because it is part of repo.or.cz's > gitweb" seems to be a weak argument. Have you even looked at the page I linked? I tried to explain how are the patches organized to branches there. Please ask if something is still unclear. -- Petr "Pasky" Baudis Early to rise and early to bed makes a male healthy and wealthy and dead. -- James Thurber ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 1:16 ` Petr Baudis @ 2007-09-01 1:23 ` Luben Tuikov 0 siblings, 0 replies; 24+ messages in thread From: Luben Tuikov @ 2007-09-01 1:23 UTC (permalink / raw) To: Petr Baudis; +Cc: git, jnareb --- Petr Baudis <pasky@suse.cz> wrote: > On Sat, Sep 01, 2007 at 03:06:02AM CEST, Luben Tuikov wrote: > > --- Petr Baudis <pasky@suse.cz> wrote: > > > Hi, > > > > > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork > > > of git at repo.or.cz: > > > > > > http://repo.or.cz/w/git/gitweb.git > > > > > > It is meant as a hub for various gitweb-related patches and > > > development efforts. So far it is pre-seeded by the patches repo.or.cz's > > > gitweb uses. > > > > Is this right? > > > > So what's the review process now? "Because it is part of repo.or.cz's > > gitweb" seems to be a weak argument. > > Have you even looked at the page I linked? I tried to explain how are > the patches organized to branches there. Please ask if something is > still unclear. Yes, I did. I saw that gitweb::master is identical to Junio's, but for safety measure I decided to ask. Thanks for your reply. Luben ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 1:06 ` Luben Tuikov 2007-09-01 1:16 ` Petr Baudis @ 2007-09-01 1:25 ` Johannes Schindelin 2007-09-01 1:31 ` Petr Baudis 2007-09-01 2:06 ` Luben Tuikov 1 sibling, 2 replies; 24+ messages in thread From: Johannes Schindelin @ 2007-09-01 1:25 UTC (permalink / raw) To: Luben Tuikov; +Cc: Petr Baudis, git, jnareb Hi, On Fri, 31 Aug 2007, Luben Tuikov wrote: > --- Petr Baudis <pasky@suse.cz> wrote: > > Hi, > > > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork > > of git at repo.or.cz: > > > > http://repo.or.cz/w/git/gitweb.git > > > > It is meant as a hub for various gitweb-related patches and > > development efforts. So far it is pre-seeded by the patches repo.or.cz's > > gitweb uses. > > Is this right? > > So what's the review process now? Umm. Pasky set it up, so it's Pasky who decides what goes in and what not. What exactly is your problem? Ciao, Dscho ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 1:25 ` Johannes Schindelin @ 2007-09-01 1:31 ` Petr Baudis 2007-09-01 1:44 ` Junio C Hamano 2007-09-01 2:06 ` Luben Tuikov 1 sibling, 1 reply; 24+ messages in thread From: Petr Baudis @ 2007-09-01 1:31 UTC (permalink / raw) To: Johannes Schindelin; +Cc: Luben Tuikov, git, jnareb Hi, On Sat, Sep 01, 2007 at 03:25:16AM CEST, Johannes Schindelin wrote: > On Fri, 31 Aug 2007, Luben Tuikov wrote: > > > --- Petr Baudis <pasky@suse.cz> wrote: > > > Hi, > > > > > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork > > > of git at repo.or.cz: > > > > > > http://repo.or.cz/w/git/gitweb.git > > > > > > It is meant as a hub for various gitweb-related patches and > > > development efforts. So far it is pre-seeded by the patches repo.or.cz's > > > gitweb uses. > > > > Is this right? > > > > So what's the review process now? > > Umm. Pasky set it up, so it's Pasky who decides what goes in and what > not. What exactly is your problem? Junio will pull from it, so he has full right to ask. :-) As I wrote in the web README, to enter #next your patch should see some git@ review; that holds for repo.or.cz patches as well as for any other patches. I suppose we will sort out the exact distinction between #next and #master on the fly; the general idea is that patches that go on #master have more or less approached perfectness. ;-) -- Petr "Pasky" Baudis Early to rise and early to bed makes a male healthy and wealthy and dead. -- James Thurber ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 1:31 ` Petr Baudis @ 2007-09-01 1:44 ` Junio C Hamano 2007-09-01 2:15 ` Luben Tuikov 0 siblings, 1 reply; 24+ messages in thread From: Junio C Hamano @ 2007-09-01 1:44 UTC (permalink / raw) To: Petr Baudis; +Cc: Johannes Schindelin, Luben Tuikov, git, jnareb Petr Baudis <pasky@suse.cz> writes: > On Sat, Sep 01, 2007 at 03:25:16AM CEST, Johannes Schindelin wrote: >> On Fri, 31 Aug 2007, Luben Tuikov wrote: >> >> > So what's the review process now? >> >> Umm. Pasky set it up, so it's Pasky who decides what goes in and what >> not. What exactly is your problem? > > Junio will pull from it, so he has full right to ask. :-) Well, I won't blindly pull from it, but honestly when it comes to gitweb I trust Pasky's judgement as much as I trust myself, if not even more. And I think the review process Pasky described is good --- people will see both the patches on the list and code in action at repo.or.cz/. I am a bit worried about the 'master' being a "StGIT stack", though. Playgrounds to be cherry-picked from (aka 'pu') would make *perfect* sense to be managed that way (and the topics that go only 'pu' of git.git itself are managed the same except that I do not do so using StGIT), but I think we need a stable history for the branch git.git will eventually pull from. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 1:44 ` Junio C Hamano @ 2007-09-01 2:15 ` Luben Tuikov 2007-09-01 4:57 ` Junio C Hamano 0 siblings, 1 reply; 24+ messages in thread From: Luben Tuikov @ 2007-09-01 2:15 UTC (permalink / raw) To: Junio C Hamano, Petr Baudis Cc: Johannes Schindelin, Luben Tuikov, git, jnareb --- Junio C Hamano <gitster@pobox.com> wrote: > Petr Baudis <pasky@suse.cz> writes: > > > On Sat, Sep 01, 2007 at 03:25:16AM CEST, Johannes Schindelin wrote: > >> On Fri, 31 Aug 2007, Luben Tuikov wrote: > >> > >> > So what's the review process now? > >> > >> Umm. Pasky set it up, so it's Pasky who decides what goes in and what > >> not. What exactly is your problem? > > > > Junio will pull from it, so he has full right to ask. :-) > > Well, I won't blindly pull from it, but honestly when it comes > to gitweb I trust Pasky's judgement as much as I trust myself, > if not even more. And I think the review process Pasky > described is good --- people will see both the patches on the > list and code in action at repo.or.cz/. > > I am a bit worried about the 'master' being a "StGIT stack", > though. Playgrounds to be cherry-picked from (aka 'pu') would > make *perfect* sense to be managed that way (and the topics that > go only 'pu' of git.git itself are managed the same except that > I do not do so using StGIT), but I think we need a stable > history for the branch git.git will eventually pull from. That was my concern too, but seeing the immediate hostility I got about asking about the review process I decided not to mention it. I'd be interesting to see how gitweb support pans out given this initial hostility to inquiry of accountability. Over the years I've seen that the best support and accountability has been had when the maintainer is not the main contributor/developer, especially for shared development. Otherwise personal preferences over feature X and Y come into play and then things get ugly. This is why you were such a good maintainer of gitweb. Luben ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 2:15 ` Luben Tuikov @ 2007-09-01 4:57 ` Junio C Hamano 0 siblings, 0 replies; 24+ messages in thread From: Junio C Hamano @ 2007-09-01 4:57 UTC (permalink / raw) To: ltuikov; +Cc: Petr Baudis, Johannes Schindelin, git, jnareb Luben Tuikov <ltuikov@yahoo.com> writes: > --- Junio C Hamano <gitster@pobox.com> wrote: > ... >> I am a bit worried about the 'master' being a "StGIT stack", >> though. Playgrounds to be cherry-picked from (aka 'pu') would >> make *perfect* sense to be managed that way (and the topics that >> go only 'pu' of git.git itself are managed the same except that >> I do not do so using StGIT), but I think we need a stable >> history for the branch git.git will eventually pull from. > > That was my concern too, but seeing the immediate hostility > I got about asking about the review process I decided not > to mention it. I do not think Johannes meant any hostility against you by mentioning the obvious "person A sets up a repository, he gets to decide rule for _his_ repository", implication of which is that anobody else can do the same. It is a completely different matter how the bits of the results are decided to be good and bad and merged as part of git.git, and that will be done with community input as always. I asked Pasky to host series of patches for various reasons. (1) I know I am less qualified than Pasky, you nor Jakub (the three people I publicly said I consider more interested in and have experience with gitweb than I am). If I were to sift through the patches, I am sure many patches will rot because of indecision. I wanted to make sure people more interested in gitweb than myself play more active role in its development and maintenance. (2) It would make it easier to view and judge the impact of pending patches if the code is used on to show various real repositories to the public. repo.or.cz is an ideal place, and Pasky has shown competence managing that service to the community. A change to gitweb may look obviously correct with just minor performance impact while code inspection, but may have scaling issues in the real world --- he will have the first hand experience to catch that. Anybody could set something like that up, but I trust the three gitweb gang more or less equally, so why not utilize the infrastructure we already have, especially Pasky agreed to help? (3) I have disagreed on a handful technical issues with Pasky, you and Jakub, but I do not expect all of us to always agree something is good or bad unanimously, nor I expect it would satisfy everybody in the community even if we agree on something unanimously, if we acted as a Cabal. One thing that is important is that the process is transparent. I trust Pasky to be open-minded as any of us would be. I do not expect him to start acting as a dictator on gitweb issues and force bad technical decisions without listening to others. I trust him at least that much. I would probably trust you or Jakub the same way, but I do not have to pick one single person that I trust _most_. As long as the person who maintains the gitweb patch queue is trusted and respected _enough_ by the community, I think that is good enough. And this is all volunteer work. Good maintainers are hard to find. > I'd be interesting to see how gitweb support pans out > given this initial hostility to inquiry of accountability. > > Over the years I've seen that the best support and accountability > has been had when the maintainer is not the main contributor/developer, > especially for shared development. Otherwise personal preferences over > feature X and Y come into play and then things get ugly. I understand your concern, and I think that is where you can help the most. If you see questionable patches queued, spot them and raise issues. We've been a friendly community, and luckily we haven't had too many burnt bridges over personality differences. We have a _LOT_ of work ahead of us in gitweb area. You may remember that there was a call-for-help from k.org gitweb master (J. H. "warthog9", with comments from HPA) some time ago. The installation there is heavily modified to support a large and heavily-hit site better than the stock gitweb, but the codebase has diverged quite a bit. We need to fold that effort back so that (1) they do not have to keep maintaining their fork, and (2) everybody else will benefit from their scalability work. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 1:25 ` Johannes Schindelin 2007-09-01 1:31 ` Petr Baudis @ 2007-09-01 2:06 ` Luben Tuikov 1 sibling, 0 replies; 24+ messages in thread From: Luben Tuikov @ 2007-09-01 2:06 UTC (permalink / raw) To: Johannes Schindelin; +Cc: Petr Baudis, git, jnareb --- Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: > Hi, > > On Fri, 31 Aug 2007, Luben Tuikov wrote: > > > --- Petr Baudis <pasky@suse.cz> wrote: > > > Hi, > > > > > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork > > > of git at repo.or.cz: > > > > > > http://repo.or.cz/w/git/gitweb.git > > > > > > It is meant as a hub for various gitweb-related patches and > > > development efforts. So far it is pre-seeded by the patches repo.or.cz's > > > gitweb uses. > > > > Is this right? > > > > So what's the review process now? > > Umm. Pasky set it up, so it's Pasky who decides what goes in and what > not. What exactly is your problem? That's perfectly fine as long as Junio doesn't pull from it ever. Now since Junio is going to pull from it, there needs to be some sort of accountability. Luben ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-08-31 0:01 [ANNOUNCE] git/gitweb.git repository Petr Baudis 2007-08-31 0:56 ` David Symonds 2007-09-01 1:06 ` Luben Tuikov @ 2007-09-01 15:15 ` Jon Smirl 2007-09-01 17:54 ` Junio C Hamano 2007-09-01 17:54 ` Jakub Narebski 2007-09-04 5:42 ` Junio C Hamano 4 siblings, 1 reply; 24+ messages in thread From: Jon Smirl @ 2007-09-01 15:15 UTC (permalink / raw) To: Petr Baudis; +Cc: git, jnareb, ltuikov On 8/30/07, Petr Baudis <pasky@suse.cz> wrote: > Hi, > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork > of git at repo.or.cz: > > http://repo.or.cz/w/git/gitweb.git > > It is meant as a hub for various gitweb-related patches and > development efforts. So far it is pre-seeded by the patches repo.or.cz's > gitweb uses. It is divided to three main branches (StGIT patchstacks in > reality), where master is what Junio is gonna pull to git's master. Using gitweb.... Since this is a patch stack, how do I get the summary log messages for just the commits on the branch without getting the log messages for the master repository mixed in? Would that give me a nice list of the pending patches? I can get the tree diffs without problem. > > Please feel encouraged to make random forks for your development > efforts, or push your random patches (preferrably just bugfixes, > something possibly controversial should be kept in safe containment like > a fork or separate branch) to the mob branch. > > Have fun, > > -- > Petr "Pasky" Baudis > Early to rise and early to bed makes a male healthy and wealthy and dead. > -- James Thurber > - > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Jon Smirl jonsmirl@gmail.com ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-01 15:15 ` Jon Smirl @ 2007-09-01 17:54 ` Junio C Hamano 0 siblings, 0 replies; 24+ messages in thread From: Junio C Hamano @ 2007-09-01 17:54 UTC (permalink / raw) To: Jon Smirl; +Cc: Petr Baudis, git, jnareb, ltuikov "Jon Smirl" <jonsmirl@gmail.com> writes: > On 8/30/07, Petr Baudis <pasky@suse.cz> wrote: >> >> due to popular (Junio's) demand, I have set up a gitweb-oriented fork >> of git at repo.or.cz: >> >> http://repo.or.cz/w/git/gitweb.git >> >> It is meant as a hub for various gitweb-related patches and >> development efforts. So far it is pre-seeded by the patches repo.or.cz's >> gitweb uses. It is divided to three main branches (StGIT patchstacks in >> reality), where master is what Junio is gonna pull to git's master. > > Using gitweb.... > Since this is a patch stack, how do I get the summary log messages for > just the commits on the branch without getting the log messages for > the master repository mixed in? Would that give me a nice list of the > pending patches? That's an excellent suggestion. I'd love to see "fork" aware gitweb myself. If a project A is "forked" repo.or.cz style to a project B, what often is interesting to see is what changes B has relative to A. In other words, you would want to view all of B except what are in A, something like: $ gitk --all --not $(git for-each-ref --format='%(objectname)' refs/remotes/A) ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-08-31 0:01 [ANNOUNCE] git/gitweb.git repository Petr Baudis ` (2 preceding siblings ...) 2007-09-01 15:15 ` Jon Smirl @ 2007-09-01 17:54 ` Jakub Narebski 2007-09-04 5:42 ` Junio C Hamano 4 siblings, 0 replies; 24+ messages in thread From: Jakub Narebski @ 2007-09-01 17:54 UTC (permalink / raw) To: Petr Baudis; +Cc: git, Luben Tuikov On Friday, 31 August 2007, Petr Baudis wrote: > Please feel encouraged to make random forks for your development > efforts, or push your random patches (preferrably just bugfixes, > something possibly controversial should be kept in safe containment > like a fork or separate branch) to the mob branch. What are the rules of pushing to the mob branch? Fetch, rebase, push? Does mob branch allows non fast-forward pushes? -- Jakub Narebski Poland ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-08-31 0:01 [ANNOUNCE] git/gitweb.git repository Petr Baudis ` (3 preceding siblings ...) 2007-09-01 17:54 ` Jakub Narebski @ 2007-09-04 5:42 ` Junio C Hamano 2007-09-04 5:47 ` Adam Roben ` (3 more replies) 4 siblings, 4 replies; 24+ messages in thread From: Junio C Hamano @ 2007-09-04 5:42 UTC (permalink / raw) To: Petr Baudis; +Cc: git, jnareb, ltuikov Here is my impressions on patches in: git://repo.or.cz/git/gitweb.git/ next * Removal of git_blame I think this makes sense; we do not need two not-so-different implementations, and the other one has been the default for quite some time. * Extra columns in blame I can see why some people especially with wide screen would want this, and toggling the display for extra columns is also a good idea. But this makes me wonder if the single button at the very top is easy to locate (maybe explain what [+] does?) and easy to access (maybe have it at the top and at least at the bottom as well?). * Incremental blame It does not seem to break the blame, but at least from where I sit accessing repo.or.cz this does not look incremental to me. The entire browser session freezes until the blame page displays in full. My local installation behaves the same way. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-04 5:42 ` Junio C Hamano @ 2007-09-04 5:47 ` Adam Roben 2007-09-04 5:50 ` Shawn O. Pearce ` (2 subsequent siblings) 3 siblings, 0 replies; 24+ messages in thread From: Adam Roben @ 2007-09-04 5:47 UTC (permalink / raw) To: Junio C Hamano; +Cc: Petr Baudis, git, jnareb, ltuikov On Sep 3, 2007, at 10:42 PM, Junio C Hamano wrote: > * Incremental blame > > It does not seem to break the blame, but at least from where I > sit accessing repo.or.cz this does not look incremental to me. > The entire browser session freezes until the blame page > displays in full. My local installation behaves the same way. For me, [1] loads incrementally as expected in Safari 3.0.3 on OS X. -Adam [1] http://repo.or.cz/w/alt-git.git?a=blame_incremental;f=git-svn.perl;h=d3c8cd0b8e3cfb97c6deb2453097c6f2e16e3bcf;hb=1e61b7640d09015213dbcae3564fa27ac6a8c151 ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-04 5:42 ` Junio C Hamano 2007-09-04 5:47 ` Adam Roben @ 2007-09-04 5:50 ` Shawn O. Pearce 2007-09-04 8:19 ` Junio C Hamano 2007-09-04 5:58 ` Andreas Ericsson 2007-09-04 7:56 ` Luben Tuikov 3 siblings, 1 reply; 24+ messages in thread From: Shawn O. Pearce @ 2007-09-04 5:50 UTC (permalink / raw) To: Junio C Hamano; +Cc: Petr Baudis, git, jnareb, ltuikov Junio C Hamano <gitster@pobox.com> wrote: > * Incremental blame > > It does not seem to break the blame, but at least from where I > sit accessing repo.or.cz this does not look incremental to me. > The entire browser session freezes until the blame page > displays in full. My local installation behaves the same way. What kind of repo are you trying that on? I haven't myself tried the gitweb incremental blame but I do know that one of my day-job repositories can take *ages* for git-gui's `git blame --incremental -C -C -w` pass. Most of the revisions for some of the blobs are far back in history, and there's a lot of files to look at for copy/movement. Plus some of that history is downright *messy* (I posted gitk screenshots of it not too long ago). I'll try to give the gitweb incremental blame a try on that repo tomorrow. -- Shawn. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-04 5:50 ` Shawn O. Pearce @ 2007-09-04 8:19 ` Junio C Hamano 0 siblings, 0 replies; 24+ messages in thread From: Junio C Hamano @ 2007-09-04 8:19 UTC (permalink / raw) To: Shawn O. Pearce; +Cc: Petr Baudis, git, jnareb, ltuikov "Shawn O. Pearce" <spearce@spearce.org> writes: > Junio C Hamano <gitster@pobox.com> wrote: >> * Incremental blame >> >> It does not seem to break the blame, but at least from where I >> sit accessing repo.or.cz this does not look incremental to me. >> The entire browser session freezes until the blame page >> displays in full. My local installation behaves the same way. > > What kind of repo are you trying that on? linux-2.6.git (block/ll_rw_blk.c). But I think I figured it out. With firebug disabled, I can see it is trying incremental. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-04 5:42 ` Junio C Hamano 2007-09-04 5:47 ` Adam Roben 2007-09-04 5:50 ` Shawn O. Pearce @ 2007-09-04 5:58 ` Andreas Ericsson 2007-09-04 9:38 ` Petr Baudis 2007-09-04 7:56 ` Luben Tuikov 3 siblings, 1 reply; 24+ messages in thread From: Andreas Ericsson @ 2007-09-04 5:58 UTC (permalink / raw) To: Junio C Hamano; +Cc: Petr Baudis, git, jnareb, ltuikov Junio C Hamano wrote: > * Incremental blame > > It does not seem to break the blame, but at least from where I > sit accessing repo.or.cz this does not look incremental to me. > The entire browser session freezes until the blame page > displays in full. My local installation behaves the same way. > This is most likely due to what browser you're using. Some don't start rendering until they've read the entire output of an URL. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-04 5:58 ` Andreas Ericsson @ 2007-09-04 9:38 ` Petr Baudis 0 siblings, 0 replies; 24+ messages in thread From: Petr Baudis @ 2007-09-04 9:38 UTC (permalink / raw) To: Andreas Ericsson; +Cc: Junio C Hamano, git, jnareb, ltuikov On Tue, Sep 04, 2007 at 07:58:53AM CEST, Andreas Ericsson wrote: > Junio C Hamano wrote: >> * Incremental blame >> It does not seem to break the blame, but at least from where I >> sit accessing repo.or.cz this does not look incremental to me. >> The entire browser session freezes until the blame page >> displays in full. My local installation behaves the same way. > > This is most likely due to what browser you're using. Some don't > start rendering until they've read the entire output of an URL. The incremental blame uses AJAX, so this shouldn't be an issue. But for some browsers it seems to take long time to actually render the new ids or something; I was reluctant about moving this particular one from next to master because I have also seen problems with it and wanted to do more tests. The benefit is mostly on files with long history buried deep in the past. -- Petr "Pasky" Baudis Early to rise and early to bed makes a male healthy and wealthy and dead. -- James Thurber ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [ANNOUNCE] git/gitweb.git repository 2007-09-04 5:42 ` Junio C Hamano ` (2 preceding siblings ...) 2007-09-04 5:58 ` Andreas Ericsson @ 2007-09-04 7:56 ` Luben Tuikov 3 siblings, 0 replies; 24+ messages in thread From: Luben Tuikov @ 2007-09-04 7:56 UTC (permalink / raw) To: Junio C Hamano, Petr Baudis; +Cc: git, jnareb, ltuikov --- Junio C Hamano <gitster@pobox.com> wrote: > Here is my impressions on patches in: > > git://repo.or.cz/git/gitweb.git/ next > > * Removal of git_blame > > I think this makes sense; we do not need two not-so-different > implementations, and the other one has been the default for > quite some time. My impression of the running gitweb installation at said site is that it doesn't implement 244a70e608204a515c214a11c43f3ecf7642533a. It is very easy to verify that it is not supported. This is a data mining feature that I use regularly. Luben > > * Extra columns in blame > > I can see why some people especially with wide screen would > want this, and toggling the display for extra columns is also > a good idea. But this makes me wonder if the single button at > the very top is easy to locate (maybe explain what [+] does?) > and easy to access (maybe have it at the top and at least at > the bottom as well?). > > * Incremental blame > > It does not seem to break the blame, but at least from where I > sit accessing repo.or.cz this does not look incremental to me. > The entire browser session freezes until the blame page > displays in full. My local installation behaves the same way. > > > > > ^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2007-09-07 6:39 UTC | newest] Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2007-08-31 0:01 [ANNOUNCE] git/gitweb.git repository Petr Baudis 2007-08-31 0:56 ` David Symonds 2007-08-31 1:00 ` David Symonds 2007-09-01 5:46 ` David Symonds 2007-09-07 6:39 ` David Symonds 2007-09-01 1:06 ` Luben Tuikov 2007-09-01 1:16 ` Petr Baudis 2007-09-01 1:23 ` Luben Tuikov 2007-09-01 1:25 ` Johannes Schindelin 2007-09-01 1:31 ` Petr Baudis 2007-09-01 1:44 ` Junio C Hamano 2007-09-01 2:15 ` Luben Tuikov 2007-09-01 4:57 ` Junio C Hamano 2007-09-01 2:06 ` Luben Tuikov 2007-09-01 15:15 ` Jon Smirl 2007-09-01 17:54 ` Junio C Hamano 2007-09-01 17:54 ` Jakub Narebski 2007-09-04 5:42 ` Junio C Hamano 2007-09-04 5:47 ` Adam Roben 2007-09-04 5:50 ` Shawn O. Pearce 2007-09-04 8:19 ` Junio C Hamano 2007-09-04 5:58 ` Andreas Ericsson 2007-09-04 9:38 ` Petr Baudis 2007-09-04 7:56 ` Luben Tuikov
Code repositories for project(s) associated with this public inbox https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).