* [PATCH] don't mention index refreshing side effect in git-status docs
@ 2007-12-09 8:21 Jeff King
2007-12-09 8:33 ` Junio C Hamano
2007-12-09 16:16 ` Jonathan del Strother
0 siblings, 2 replies; 5+ messages in thread
From: Jeff King @ 2007-12-09 8:21 UTC (permalink / raw
To: Junio C Hamano; +Cc: Steven Grimm, git
The tip about speeding up subsequent operations is now
obsolete; since aecbf914, git-diff now squelches empty diffs
and performs an automatic refresh.
Signed-off-by: Jeff King <peff@peff.net>
---
This is on top of my other patches to the git-status docs.
I don't see any reason to mention this side effect at all. Those who
know enough to set diff.autorefreshindex presumably know what they are
doing, and the removed paragraph is a bit confusing to those who don't.
If there is some desire to document the side effect, I think we should
at least remove the mention of speeding up git-diff (which is just wrong
now).
Documentation/git-status.txt | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/Documentation/git-status.txt b/Documentation/git-status.txt
index a1bb9bd..5c5a480 100644
--- a/Documentation/git-status.txt
+++ b/Documentation/git-status.txt
@@ -28,13 +28,6 @@ If there is no path that is different between the index file and
the current HEAD commit (i.e., there is nothing to commit by running
`git-commit`), the command exits with non-zero status.
-If any paths have been touched in the working tree (that is,
-their modification times have changed) but their contents and
-permissions are identical to those in the index file, the command
-updates the index file. Running `git-status` can thus speed up
-subsequent operations such as `git-diff` if the working tree
-contains many paths that have been touched but not modified.
-
OUTPUT
------
--
1.5.3.7.2187.gb646
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] don't mention index refreshing side effect in git-status docs
2007-12-09 8:21 [PATCH] don't mention index refreshing side effect in git-status docs Jeff King
@ 2007-12-09 8:33 ` Junio C Hamano
2007-12-09 8:42 ` Jeff King
2007-12-09 16:16 ` Jonathan del Strother
1 sibling, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2007-12-09 8:33 UTC (permalink / raw
To: Jeff King; +Cc: Steven Grimm, git
Jeff King <peff@peff.net> writes:
> If there is some desire to document the side effect, I think we should
> at least remove the mention of speeding up git-diff (which is just wrong
> now).
Why is it "just wrong"? Having to squelch the false hits and to run
auto-refresh are both unnecessary overhead if your index is fresh.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] don't mention index refreshing side effect in git-status docs
2007-12-09 8:33 ` Junio C Hamano
@ 2007-12-09 8:42 ` Jeff King
0 siblings, 0 replies; 5+ messages in thread
From: Jeff King @ 2007-12-09 8:42 UTC (permalink / raw
To: Junio C Hamano; +Cc: Steven Grimm, git
On Sun, Dec 09, 2007 at 12:33:19AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > If there is some desire to document the side effect, I think we should
> > at least remove the mention of speeding up git-diff (which is just wrong
> > now).
>
> Why is it "just wrong"? Having to squelch the false hits and to run
> auto-refresh are both unnecessary overhead if your index is fresh.
I mean that this is not a useful technique for speeding up git-diff
anymore (assuming you have not tinkered with autorefreshindex, in which
case I assume you know what you are doing and don't need this tip).
Did you think I meant "there is no speedup with autorefreshindex off",
or are you arguing that even with the new diff behavior there is still a
speedup in "git status; git diff" over just "git status"?
-Peff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] don't mention index refreshing side effect in git-status docs
2007-12-09 8:21 [PATCH] don't mention index refreshing side effect in git-status docs Jeff King
2007-12-09 8:33 ` Junio C Hamano
@ 2007-12-09 16:16 ` Jonathan del Strother
2007-12-09 18:15 ` Junio C Hamano
1 sibling, 1 reply; 5+ messages in thread
From: Jonathan del Strother @ 2007-12-09 16:16 UTC (permalink / raw
To: git
On Dec 9, 2007 8:21 AM, Jeff King <peff@peff.net> wrote:
> The tip about speeding up subsequent operations is now
> obsolete; since aecbf914, git-diff now squelches empty diffs
> and performs an automatic refresh.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> This is on top of my other patches to the git-status docs.
>
> I don't see any reason to mention this side effect at all. Those who
> know enough to set diff.autorefreshindex presumably know what they are
> doing, and the removed paragraph is a bit confusing to those who don't.
>
... I wasn't aware the index needed refreshing. This might be
totally unrelated to the present conversation, but the GIT-VERSION-GEN
script occasionally gives me spurious 'dirty' results (eg when a file
timestamp changes despite the content having changed). Should it
perhaps be running "git update-index --refresh" before it runs "git
diff-index --name-only HEAD" ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] don't mention index refreshing side effect in git-status docs
2007-12-09 16:16 ` Jonathan del Strother
@ 2007-12-09 18:15 ` Junio C Hamano
0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2007-12-09 18:15 UTC (permalink / raw
To: Jonathan del Strother; +Cc: git
"Jonathan del Strother" <maillist@steelskies.com> writes:
> ... the GIT-VERSION-GEN
> script occasionally gives me spurious 'dirty' results (eg when a file
> timestamp changes despite the content having changed).
Good eyes. Either refreshing before diff-index or using the "git diff"
Porcelain would be more appropriate.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-12-09 18:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-09 8:21 [PATCH] don't mention index refreshing side effect in git-status docs Jeff King
2007-12-09 8:33 ` Junio C Hamano
2007-12-09 8:42 ` Jeff King
2007-12-09 16:16 ` Jonathan del Strother
2007-12-09 18:15 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).