git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>, <git@vger.kernel.org>
Subject: Re: [PATCH] Choose XDL_FAST_HASH code on sizeof(long) instead of __WORDSIZE
Date: Tue, 01 May 2012 10:33:30 -0700	[thread overview]
Message-ID: <7vhavzajrp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <399c9a1f0dd548da3144eff3c50d04a8f343ab24.1335860033.git.trast@student.ethz.ch> (Thomas Rast's message of "Tue, 1 May 2012 10:36:51 +0200")

Thomas Rast <trast@student.ethz.ch> writes:

> Darwin does not define __WORDSIZE, and compiles the 32-bit code path
> on 64-bit systems, resulting in a totally broken git.
>
> I could not find an alternative -- other than the platform symbols
> (__x86_64__ etc.) -- that does the test in the preprocessor.  However,
> we can also just test for the size of a 'long', which is what really
> matters here.  Any compiler worth its salt will leave only the branch
> relevant for its platform, and indeed on Linux/GCC the numbers don't
> change:

Thanks.

  reply	other threads:[~2012-05-01 17:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-29 20:52 XDL_FAST_HASH breaks git on OS X 10.7.3 Brian Gernhardt
2012-04-30 16:38 ` Thomas Rast
2012-05-01  2:13   ` Brian Gernhardt
2012-05-01  4:39     ` Junio C Hamano
2012-05-01  4:41       ` Junio C Hamano
2012-05-01  8:36         ` [PATCH] Choose XDL_FAST_HASH code on sizeof(long) instead of __WORDSIZE Thomas Rast
2012-05-01 17:33           ` Junio C Hamano [this message]
2012-05-01  5:32   ` XDL_FAST_HASH breaks git on OS X 10.7.3 David Aguilar
2012-05-01  6:17     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhavzajrp.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).