git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Rémi Vanicat" <vanicat@debian.org>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [BUGS] test failure in t4014-format-patch.sh with master
Date: Fri, 18 Apr 2008 23:51:08 -0700	[thread overview]
Message-ID: <7vfxtiibhf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 6b8a91420804181513m139baf06x41d8efeb7acd49a3@mail.gmail.com

"Rémi Vanicat" <vanicat@debian.org> writes:

> 2008/4/18, Linus Torvalds <torvalds@linux-foundation.org>:
>>
>>
>>  On Fri, 18 Apr 2008, Junio C Hamano wrote:
>>  >
>>  > -             (echo "$SUBJECT" ; echo ; cat "$dotest/msg") |
>>  > +             (printf '%s\n' "$SUBJECT" ; echo ; cat "$dotest/msg") |
>>
>>
>> Well, get rid of the superfluous second 'echo' then too, replacing it
>>  with another '\n'. IOW:
>>
>>         ( printf '%s\n\n' "$SUBJECT" ; cat "$dotest/msg" ) |
>>
>>  instead.
>
> This work for me: no more test failure on my computer

Thanks for confirmation.  I reproduced the breakage and the fix myself
with "make SHELL_PATH=/bin/dash" myself, too.

      reply	other threads:[~2008-04-19  6:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17  9:30 [BUGS] test failure in t4014-format-patch.sh with master Remi Vanicat
2008-04-17 15:11 ` Linus Torvalds
2008-04-17 15:34   ` Björn Steinbrink
2008-04-17 15:44     ` Linus Torvalds
2008-04-17 16:03       ` Björn Steinbrink
2008-04-17 16:24       ` Jeff King
2008-04-17 16:27         ` Jeff King
2008-04-17 15:44   ` Rémi Vanicat
2008-04-18 18:30     ` Junio C Hamano
2008-04-18 18:37       ` Linus Torvalds
2008-04-18 22:13         ` Rémi Vanicat
2008-04-19  6:51           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfxtiibhf.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vanicat@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).