git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: David Abrahams <dave@boostpro.com>, git@vger.kernel.org
Subject: Re: "malloc failed"
Date: Wed, 28 Jan 2009 23:53:25 -0800	[thread overview]
Message-ID: <7vfxj2h7ka.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090129055633.GA32609@coredump.intra.peff.net

Jeff King <peff@peff.net> writes:

> Subject: [PATCH] avoid 31-bit truncation in write_loose_object
>
> The size of the content we are adding may be larger than
> 2.1G (i.e., "git add gigantic-file"). Most of the code-path
> to do so uses size_t or unsigned long to record the size,
> but write_loose_object uses a signed int.

Thanks.

I wonder if some analysis tool like sparse can help us spot these...

  reply	other threads:[~2009-01-29  7:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27 15:04 "malloc failed" David Abrahams
2009-01-27 15:29 ` Shawn O. Pearce
2009-01-27 15:32   ` David Abrahams
2009-01-27 18:02 ` Johannes Schindelin
2009-01-28  5:02 ` Jeff King
2009-01-28 21:53   ` David Abrahams
2009-01-29  0:06     ` David Abrahams
2009-01-29  5:20       ` Jeff King
2009-01-29  5:56         ` Jeff King
2009-01-29  7:53           ` Junio C Hamano [this message]
2009-01-29 13:10           ` David Abrahams
2009-01-29 13:41             ` Andreas Ericsson
2009-01-30  4:49             ` Jeff King
2009-01-28 22:16   ` Pau Garcia i Quiles
2009-01-29  5:14     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfxj2h7ka.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=dave@boostpro.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).